Changeset 27351 in webkit

Timestamp:

Nov 1, 2007, 8:30:23 AM (17 years ago)

Author:

mitz

Message:

WebCore:

Reviewed by Dave Hyatt.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=15015 <rdar://problem/5420308> Most of www.aol.com redraws unnecessarily when headline/photo section changes

Test: fast/repaint/overflow-clip-subtree-layout.html

This patch does not address the bigger issue of doing a full relayout
of inline flows containing floats, but it addresses the problem on
aol.com, where the changes that trigger layout are confined to an
overflow area inside the float.

• page/FrameView.cpp: (WebCore::FrameView::scheduleRelayoutOfSubtree): If the new and old layout roots are different but one descends from the other, make (or keep) the ancestor as the layout root.
• rendering/RenderObject.cpp: (WebCore::objectIsRelayoutBoundary): Made boxes with overflow clipping and non-auto width and height relayout boundaries.

LayoutTests:

Reviewed by Dave Hyatt.

• repaint test for ​http://bugs.webkit.org/show_bug.cgi?id=15015 <rdar://problem/5420308> Most of www.aol.com redraws unnecessarily when headline/photo section changes

• fast/repaint/overflow-clip-subtree-layout.html: Added.
• platform/mac/fast/repaint/overflow-clip-subtree-layout-expected.checksum: Added.
• platform/mac/fast/repaint/overflow-clip-subtree-layout-expected.png: Added.
• platform/mac/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/repaint/overflow-clip-subtree-layout.html (added)
• LayoutTests/platform/mac/fast/repaint/overflow-clip-subtree-layout-expected.checksum (added)
• LayoutTests/platform/mac/fast/repaint/overflow-clip-subtree-layout-expected.png (added)
• LayoutTests/platform/mac/fast/repaint/overflow-clip-subtree-layout-expected.txt (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/page/FrameView.cpp (modified) (1 diff)
• WebCore/rendering/RenderObject.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-11-01  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Dave Hyatt.
+
+        - repaint test for http://bugs.webkit.org/show_bug.cgi?id=15015
+          <rdar://problem/5420308> Most of www.aol.com redraws unnecessarily when headline/photo section changes
+
+        * fast/repaint/overflow-clip-subtree-layout.html: Added.
+        * platform/mac/fast/repaint/overflow-clip-subtree-layout-expected.checksum: Added.
+        * platform/mac/fast/repaint/overflow-clip-subtree-layout-expected.png: Added.
+        * platform/mac/fast/repaint/overflow-clip-subtree-layout-expected.txt: Added.
+
 2007-10-31  Adam Roben  <aroben@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-11-01  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Dave Hyatt.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=15015
+          <rdar://problem/5420308> Most of www.aol.com redraws unnecessarily when headline/photo section changes
+
+        Test: fast/repaint/overflow-clip-subtree-layout.html
+
+        This patch does not address the bigger issue of doing a full relayout
+        of inline flows containing floats, but it addresses the problem on
+        aol.com, where the changes that trigger layout are confined to an
+        overflow area inside the float.
+
+        * page/FrameView.cpp:
+        (WebCore::FrameView::scheduleRelayoutOfSubtree): If the new and old
+        layout roots are different but one descends from the other, make (or
+        keep) the ancestor as the layout root.
+        * rendering/RenderObject.cpp:
+        (WebCore::objectIsRelayoutBoundary): Made boxes with overflow
+        clipping and non-auto width and height relayout boundaries.
+
 2007-11-01  Alexey Proskuryakov  <ap@webkit.org>
 

trunk/WebCore/page/FrameView.cpp

@@ -730 +730 @@
     if (layoutPending()) {
         if (d->layoutRoot != n) {
-            // Just do a full relayout
-            if (d->layoutRoot && d->layoutRoot->renderer())
-                d->layoutRoot->renderer()->markContainingBlocksForLayout(false);
-            d->layoutRoot = 0;
-            if (n->renderer())
-                n->renderer()->markContainingBlocksForLayout(false);
+            if (n->isDescendantOf(d->layoutRoot.get())) {
+                // Keep the current root
+                if (n->renderer())
+                    n->renderer()->markContainingBlocksForLayout(false);
+            } else if (d->layoutRoot && d->layoutRoot->isDescendantOf(n)) {
+                // Re-root at n
+                if (d->layoutRoot->renderer())
+                    d->layoutRoot->renderer()->markContainingBlocksForLayout(false);
+                d->layoutRoot = n;
+            } else {
+                // Just do a full relayout
+                if (d->layoutRoot && d->layoutRoot->renderer())
+                    d->layoutRoot->renderer()->markContainingBlocksForLayout(false);
+                d->layoutRoot = 0;
+                if (n->renderer())
+                    n->renderer()->markContainingBlocksForLayout(false);
+            }
         }
     } else {

trunk/WebCore/rendering/RenderObject.cpp

@@ -711 +711 @@
     // FIXME: In future it may be possible to broaden this condition in order to improve performance 
     return obj->isTextField() || obj->isTextArea()
+        || obj->hasOverflowClip() && !obj->style()->width().isIntrinsicOrAuto() && !obj->style()->height().isIntrinsicOrAuto()
 #if ENABLE(SVG)
            || obj->isSVGRoot()