Changeset 273725 in webkit

Timestamp:

Mar 2, 2021, 1:18:12 AM (6 years ago)

Author:

youenn@apple.com

Message:

Camera capture in iOS with GPUProcess enabled does not always handle orientation well at start up
​https://bugs.webkit.org/show_bug.cgi?id=222167
<rdar://problem/74520496>

Reviewed by Eric Carlson.

Before the patch, GPU process orientation monitors were only getting updates after creation of the web process connection.
The initial value was therefore sometimes wrong.
Update this by storing the orientation value in GPU process and initializing it for every web process connection.
Manually tested.

• GPUProcess/GPUProcess.cpp:

(WebKit::GPUProcess::createGPUConnectionToWebProcess):
(WebKit::GPUProcess::setOrientationForMediaCapture):

• GPUProcess/GPUProcess.h:

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• GPUProcess/GPUProcess.cpp (modified) (2 diffs)
• GPUProcess/GPUProcess.h (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-03-02  Youenn Fablet  <youenn@apple.com>
+
+        Camera capture in iOS with GPUProcess enabled does not always handle orientation well at start up
+        https://bugs.webkit.org/show_bug.cgi?id=222167
+        <rdar://problem/74520496>
+
+        Reviewed by Eric Carlson.
+
+        Before the patch, GPU process orientation monitors were only getting updates after creation of the web process connection.
+        The initial value was therefore sometimes wrong.
+        Update this by storing the orientation value in GPU process and initializing it for every web process connection.
+        Manually tested.
+
+        * GPUProcess/GPUProcess.cpp:
+        (WebKit::GPUProcess::createGPUConnectionToWebProcess):
+        (WebKit::GPUProcess::setOrientationForMediaCapture):
+        * GPUProcess/GPUProcess.h:
+
 2021-03-01  Fujii Hironori  <Hironori.Fujii@sony.com>
 

trunk/Source/WebKit/GPUProcess/GPUProcess.cpp

@@ -98 +98 @@
     auto access = m_mediaCaptureAccessMap.take(identifier);
     newConnection->updateCaptureAccess(access.allowAudioCapture, access.allowVideoCapture, access.allowDisplayCapture);
+    newConnection->setOrientationForMediaCapture(m_orientation);
 #endif
 
@@ -212 +213 @@
 void GPUProcess::setOrientationForMediaCapture(uint64_t orientation)
 {
+    m_orientation = orientation;
     for (auto& connection : m_webProcessConnections.values())
         connection->setOrientationForMediaCapture(orientation);

trunk/Source/WebKit/GPUProcess/GPUProcess.h

@@ -134 +134 @@
     RefPtr<WorkQueue> m_videoMediaStreamTrackRendererQueue;
 #endif
+    uint64_t m_orientation { 0 };
 #endif
 #if USE(LIBWEBRTC) && PLATFORM(COCOA)