Changeset 273727 in webkit

Timestamp:

Mar 2, 2021, 2:15:10 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Null check platformData when decoding
​https://bugs.webkit.org/show_bug.cgi?id=221442

Patch by Rob Buis <​rbuis@igalia.com> on 2021-03-02
Reviewed by Ryosuke Niwa.

Source/WebKit:

Null check platformData when decoding.

Test: ipc/pasteboard-write-custom-data.html

• Shared/WebCoreArgumentCoders.cpp:

(IPC::ArgumentCoder<PasteboardCustomData::Entry>::decode):

LayoutTests:

Add test for this.

• ipc/pasteboard-write-custom-data-expected.txt: Added.
• ipc/pasteboard-write-custom-data.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/ipc/pasteboard-write-custom-data-expected.txt (added)
• LayoutTests/ipc/pasteboard-write-custom-data.html (added)
• Source/WebKit/ChangeLog (modified) (1 diff)
• Source/WebKit/Shared/WebCoreArgumentCoders.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-03-02  Rob Buis  <rbuis@igalia.com>
+
+        Null check platformData when decoding
+        https://bugs.webkit.org/show_bug.cgi?id=221442
+
+        Reviewed by Ryosuke Niwa.
+
+        Add test for this.
+
+        * ipc/pasteboard-write-custom-data-expected.txt: Added.
+        * ipc/pasteboard-write-custom-data.html: Added.
+
 2021-03-01  Fujii Hironori  <Hironori.Fujii@sony.com>
 

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-03-02  Rob Buis  <rbuis@igalia.com>
+
+        Null check platformData when decoding
+        https://bugs.webkit.org/show_bug.cgi?id=221442
+
+        Reviewed by Ryosuke Niwa.
+
+        Null check platformData when decoding.
+
+        Test: ipc/pasteboard-write-custom-data.html
+
+        * Shared/WebCoreArgumentCoders.cpp:
+        (IPC::ArgumentCoder<PasteboardCustomData::Entry>::decode):
+
 2021-03-02  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebKit/Shared/WebCoreArgumentCoders.cpp

@@ -1572 +1572 @@
     if (hasBuffer) {
         RefPtr<SharedBuffer> value;
-        if (!decodeSharedBuffer(decoder, value))
+        if (!decodeSharedBuffer(decoder, value) || !value)
             return false;
         data.platformData = { value.releaseNonNull() };