Changeset 273731 in webkit

Timestamp:

Mar 2, 2021, 8:31:54 AM (6 years ago)

Author:

calvaris@igalia.com

Message:

[GStreamer] Error instead of asserting on the player in the source
​https://bugs.webkit.org/show_bug.cgi?id=222108

Reviewed by Philippe Normand.

The release assert can be hit in some cases in smoothstreaming
with already invalid pipelines so better to just error out instead
of assert on release.

• platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:

(webKitWebSrcCreate):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-03-02  Xabier Rodriguez Calvar  <calvaris@igalia.com>
+
+        [GStreamer] Error instead of asserting on the player in the source
+        https://bugs.webkit.org/show_bug.cgi?id=222108
+
+        Reviewed by Philippe Normand.
+
+        The release assert can be hit in some cases in smoothstreaming
+        with already invalid pipelines so better to just error out instead
+        of assert on release.
+
+        * platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp:
+        (webKitWebSrcCreate):
+
 2021-03-02  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/WebKitWebSourceGStreamer.cpp

@@ -481 +481 @@
             return GST_FLOW_FLUSHING;
     }
-    RELEASE_ASSERT(members->player);
+    if (!members->player) {
+        GST_ERROR_OBJECT(src, "Couldn't obtain WebKitWebSrcPlayerContext, which is necessary to make network requests");
+        return GST_FLOW_ERROR;
+    }
 
     GST_TRACE_OBJECT(src, "readPosition = %" G_GUINT64_FORMAT " requestedPosition = %" G_GUINT64_FORMAT, members->readPosition, members->requestedPosition);