⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 273751 in webkit


Ignore:
Timestamp:
Mar 2, 2021, 12:03:12 PM (6 years ago)
Author:
achristensen@apple.com
Message:

[Cocoa] REGRESSION(r272752): fix some internal builds that use WTFString::WTFString(NSString *)
​https://bugs.webkit.org/show_bug.cgi?id=222610
<rdar://74938249>

Unreviewed build fix.

Patch by BJ Burg <BJ Burg> on 2021-03-02

  • inspector/scripts/codegen/generate_objc_protocol_type_conversions_implementation.py:

(ObjCProtocolTypeConversionsImplementationGenerator._generate_type_factory_method_implementation):
Some builders seem to find the new version of the header (without the exported NSString constructor)
whereas others don't find the new version (expecting the symbol to be exported), causing a linker error later on.

As a workaround, force usage of the CFStringRef constructor, which is always exported.

  • inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
  • inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
  • inspector/scripts/tests/expected/enum-values.json-result:
  • inspector/scripts/tests/expected/type-declaration-array-type.json-result:
  • inspector/scripts/tests/expected/type-declaration-enum-type.json-result:
  • inspector/scripts/tests/expected/type-declaration-object-type.json-result:
  • inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:

Rebaseline generator test results.

Location:
trunk/Source/JavaScriptCore
Files:
9 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/JavaScriptCore/ChangeLog

    r273750 r273751  
     12021-03-02  BJ Burg  <bburg@apple.com>
     2
     3        [Cocoa] REGRESSION(r272752): fix some internal builds that use WTFString::WTFString(NSString *)
     4        https://bugs.webkit.org/show_bug.cgi?id=222610
     5        <rdar://74938249>
     6
     7        Unreviewed build fix.
     8
     9        * inspector/scripts/codegen/generate_objc_protocol_type_conversions_implementation.py:
     10        (ObjCProtocolTypeConversionsImplementationGenerator._generate_type_factory_method_implementation):
     11        Some builders seem to find the new version of the header (without the exported NSString constructor)
     12        whereas others don't find the new version (expecting the symbol to be exported), causing a linker error later on.
     13
     14        As a workaround, force usage of the CFStringRef constructor, which is always exported.
     15
     16        * inspector/scripts/tests/expected/commands-with-async-attribute.json-result:
     17        * inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result:
     18        * inspector/scripts/tests/expected/enum-values.json-result:
     19        * inspector/scripts/tests/expected/type-declaration-array-type.json-result:
     20        * inspector/scripts/tests/expected/type-declaration-enum-type.json-result:
     21        * inspector/scripts/tests/expected/type-declaration-object-type.json-result:
     22        * inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result:
     23        Rebaseline generator test results.
     24
    1252021-03-02  Alexey Shvayka  <shvaikalesh@gmail.com>
    226

  • trunk/Source/JavaScriptCore/inspector/scripts/codegen/generate_objc_protocol_type_conversions_implementation.py

    r262203 r273751  
    136136        if isinstance(resolved_type, EnumType):
    137137            lines.append('    THROW_EXCEPTION_FOR_BAD_TYPE(payload, [NSString class]);')
    138             lines.append('    Optional<%(type)s> result = Inspector::fromProtocolString<%(type)s>(payload);' % {'type': self.objc_name_for_type(resolved_type)})
     138            lines.append('    Optional<%(type)s> result = Inspector::fromProtocolString<%(type)s>((__bridge CFStringRef)payload);' % {'type': self.objc_name_for_type(resolved_type)})
    139139            lines.append('    THROW_EXCEPTION_FOR_BAD_ENUM_VALUE(result, @"%s");' % declaration.type.raw_name())
    140140            lines.append('    *outValue = @(result.value());')

  • trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/commands-with-async-attribute.json-result

    r272936 r273751  
    15971597{
    15981598    THROW_EXCEPTION_FOR_BAD_TYPE(payload, [NSString class]);
    1599     Optional<TestProtocolDatabasePrimaryColors> result = Inspector::fromProtocolString<TestProtocolDatabasePrimaryColors>(payload);
     1599    Optional<TestProtocolDatabasePrimaryColors> result = Inspector::fromProtocolString<TestProtocolDatabasePrimaryColors>((__bridge CFStringRef)payload);
    16001600    THROW_EXCEPTION_FOR_BAD_ENUM_VALUE(result, @"PrimaryColors");
    16011601    *outValue = @(result.value());

  • trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/commands-with-optional-call-return-parameters.json-result

    r272936 r273751  
    14701470{
    14711471    THROW_EXCEPTION_FOR_BAD_TYPE(payload, [NSString class]);
    1472     Optional<TestProtocolDatabasePrimaryColors> result = Inspector::fromProtocolString<TestProtocolDatabasePrimaryColors>(payload);
     1472    Optional<TestProtocolDatabasePrimaryColors> result = Inspector::fromProtocolString<TestProtocolDatabasePrimaryColors>((__bridge CFStringRef)payload);
    14731473    THROW_EXCEPTION_FOR_BAD_ENUM_VALUE(result, @"PrimaryColors");
    14741474    *outValue = @(result.value());

  • trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/enum-values.json-result

    r272936 r273751  
    11681168{
    11691169    THROW_EXCEPTION_FOR_BAD_TYPE(payload, [NSString class]);
    1170     Optional<TestProtocolTypeDomainEnum> result = Inspector::fromProtocolString<TestProtocolTypeDomainEnum>(payload);
     1170    Optional<TestProtocolTypeDomainEnum> result = Inspector::fromProtocolString<TestProtocolTypeDomainEnum>((__bridge CFStringRef)payload);
    11711171    THROW_EXCEPTION_FOR_BAD_ENUM_VALUE(result, @"Enum");
    11721172    *outValue = @(result.value());

  • trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/type-declaration-array-type.json-result

    r272936 r273751  
    919919{
    920920    THROW_EXCEPTION_FOR_BAD_TYPE(payload, [NSString class]);
    921     Optional<TestProtocolDebuggerReason> result = Inspector::fromProtocolString<TestProtocolDebuggerReason>(payload);
     921    Optional<TestProtocolDebuggerReason> result = Inspector::fromProtocolString<TestProtocolDebuggerReason>((__bridge CFStringRef)payload);
    922922    THROW_EXCEPTION_FOR_BAD_ENUM_VALUE(result, @"Reason");
    923923    *outValue = @(result.value());

  • trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/type-declaration-enum-type.json-result

    r272936 r273751  
    963963{
    964964    THROW_EXCEPTION_FOR_BAD_TYPE(payload, [NSString class]);
    965     Optional<TestProtocolRuntimeFarmAnimals> result = Inspector::fromProtocolString<TestProtocolRuntimeFarmAnimals>(payload);
     965    Optional<TestProtocolRuntimeFarmAnimals> result = Inspector::fromProtocolString<TestProtocolRuntimeFarmAnimals>((__bridge CFStringRef)payload);
    966966    THROW_EXCEPTION_FOR_BAD_ENUM_VALUE(result, @"FarmAnimals");
    967967    *outValue = @(result.value());
    … …  
    971971{
    972972    THROW_EXCEPTION_FOR_BAD_TYPE(payload, [NSString class]);
    973     Optional<TestProtocolRuntimeTwoLeggedAnimals> result = Inspector::fromProtocolString<TestProtocolRuntimeTwoLeggedAnimals>(payload);
     973    Optional<TestProtocolRuntimeTwoLeggedAnimals> result = Inspector::fromProtocolString<TestProtocolRuntimeTwoLeggedAnimals>((__bridge CFStringRef)payload);
    974974    THROW_EXCEPTION_FOR_BAD_ENUM_VALUE(result, @"TwoLeggedAnimals");
    975975    *outValue = @(result.value());

  • trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/type-declaration-object-type.json-result

    r272936 r273751  
    17051705{
    17061706    THROW_EXCEPTION_FOR_BAD_TYPE(payload, [NSString class]);
    1707     Optional<TestProtocolDatabaseMouseButton> result = Inspector::fromProtocolString<TestProtocolDatabaseMouseButton>(payload);
     1707    Optional<TestProtocolDatabaseMouseButton> result = Inspector::fromProtocolString<TestProtocolDatabaseMouseButton>((__bridge CFStringRef)payload);
    17081708    THROW_EXCEPTION_FOR_BAD_ENUM_VALUE(result, @"MouseButton");
    17091709    *outValue = @(result.value());

  • trunk/Source/JavaScriptCore/inspector/scripts/tests/expected/type-requiring-runtime-casts.json-result

    r272936 r273751  
    13261326{
    13271327    THROW_EXCEPTION_FOR_BAD_TYPE(payload, [NSString class]);
    1328     Optional<TestProtocolTestUncastedAnimals> result = Inspector::fromProtocolString<TestProtocolTestUncastedAnimals>(payload);
     1328    Optional<TestProtocolTestUncastedAnimals> result = Inspector::fromProtocolString<TestProtocolTestUncastedAnimals>((__bridge CFStringRef)payload);
    13291329    THROW_EXCEPTION_FOR_BAD_ENUM_VALUE(result, @"UncastedAnimals");
    13301330    *outValue = @(result.value());
    … …  
    13341334{
    13351335    THROW_EXCEPTION_FOR_BAD_TYPE(payload, [NSString class]);
    1336     Optional<TestProtocolTestCastedAnimals> result = Inspector::fromProtocolString<TestProtocolTestCastedAnimals>(payload);
     1336    Optional<TestProtocolTestCastedAnimals> result = Inspector::fromProtocolString<TestProtocolTestCastedAnimals>((__bridge CFStringRef)payload);
    13371337    THROW_EXCEPTION_FOR_BAD_ENUM_VALUE(result, @"CastedAnimals");
    13381338    *outValue = @(result.value());
Note: See TracChangeset for help on using the changeset viewer.