Changeset 273775 in webkit

Timestamp:

Mar 2, 2021, 5:12:53 PM (6 years ago)

Author:

Peng Liu

Message:

[ BigSur Debug Wk 2 ] ASSERT NOT REACHED in WebCore::DisplayList::PaintFrameForMedia::apply
​https://bugs.webkit.org/show_bug.cgi?id=221989
<rdar://problem/74403030>

Reviewed by Jer Noble.

No new tests, this will fix a crash on debug bots.

• GPUProcess/graphics/RemoteRenderingBackend.cpp:

(WebKit::RemoteRenderingBackend::applyMediaItem): When we cannot get the player, the player
with the given identifier must have been destroyed. This function can return true to indicate
that the item has been applied.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• GPUProcess/graphics/RemoteRenderingBackend.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-03-02  Peng Liu  <peng.liu6@apple.com>
+
+        [ BigSur Debug Wk 2 ] ASSERT NOT REACHED in WebCore::DisplayList::PaintFrameForMedia::apply
+        https://bugs.webkit.org/show_bug.cgi?id=221989
+        <rdar://problem/74403030>
+
+        Reviewed by Jer Noble.
+
+        No new tests, this will fix a crash on debug bots.
+
+        * GPUProcess/graphics/RemoteRenderingBackend.cpp:
+        (WebKit::RemoteRenderingBackend::applyMediaItem): When we cannot get the player, the player
+        with the given identifier must have been destroyed. This function can return true to indicate
+        that the item has been applied.
+
 2021-03-02  Ricky Mondello  <rmondello@apple.com>
 

trunk/Source/WebKit/GPUProcess/graphics/RemoteRenderingBackend.cpp

@@ -125 +125 @@
     auto player = m_gpuConnectionToWebProcess->remoteMediaPlayerManagerProxy().mediaPlayer(mediaItem.identifier());
     if (!player)
-        return false;
+        return true;
 
     context.paintFrameForMedia(*player, mediaItem.destination());