⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 273791 in webkit


Ignore:
Timestamp:
Mar 2, 2021, 7:08:34 PM (6 years ago)
Author:
Alan Coon
Message:

Cherry-pick r273314. rdar://problem/74953186

aspect-ratio shows in computed style when disabled
​https://bugs.webkit.org/show_bug.cgi?id=222286

Patch by Rob Buis <​rbuis@igalia.com> on 2021-02-23
Reviewed by Simon Fraser.

Source/WebCore:

Make aspect-ratio invisible from style when disabled.

Test: fast/css/aspect-ratio-invalidate-if-disabled.html

  • css/CSSComputedStyleDeclaration.cpp: (WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
  • css/CSSProperties.json:

Tools:

Add support for disabling aspect-ratio in wk1.

  • DumpRenderTree/TestOptions.cpp: (WTR::TestOptions::defaults):

LayoutTests:

Add test.

  • fast/css/aspect-ratio-invalidate-if-disabled-expected.txt: Added.
  • fast/css/aspect-ratio-invalidate-if-disabled.html: Added.

git-svn-id: ​https://svn.webkit.org/repository/webkit/trunk@273314 268f45cc-cd09-0410-ab3c-d52691b4dbfc

Location:
branches/safari-612.1.5-branch
Files:
2 added
6 edited

Legend:

Unmodified
Added
Removed

  • branches/safari-612.1.5-branch/LayoutTests/ChangeLog

    r273228 r273791  
     12021-03-02  Alan Coon  <alancoon@apple.com>
     2
     3        Cherry-pick r273314. rdar://problem/74953186
     4
     5    aspect-ratio shows in computed style when disabled
     6    https://bugs.webkit.org/show_bug.cgi?id=222286
     7   
     8    Patch by Rob Buis <rbuis@igalia.com> on 2021-02-23
     9    Reviewed by Simon Fraser.
     10   
     11    Source/WebCore:
     12   
     13    Make aspect-ratio invisible from style when disabled.
     14   
     15    Test: fast/css/aspect-ratio-invalidate-if-disabled.html
     16   
     17    * css/CSSComputedStyleDeclaration.cpp:
     18    (WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
     19    * css/CSSProperties.json:
     20   
     21    Tools:
     22   
     23    Add support for disabling aspect-ratio in wk1.
     24   
     25    * DumpRenderTree/TestOptions.cpp:
     26    (WTR::TestOptions::defaults):
     27   
     28    LayoutTests:
     29   
     30    Add test.
     31   
     32    * fast/css/aspect-ratio-invalidate-if-disabled-expected.txt: Added.
     33    * fast/css/aspect-ratio-invalidate-if-disabled.html: Added.
     34   
     35    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273314 268f45cc-cd09-0410-ab3c-d52691b4dbfc
     36
     37    2021-02-23  Rob Buis  <rbuis@igalia.com>
     38
     39            aspect-ratio shows in computed style when disabled
     40            https://bugs.webkit.org/show_bug.cgi?id=222286
     41
     42            Reviewed by Simon Fraser.
     43
     44            Add test.
     45
     46            * fast/css/aspect-ratio-invalidate-if-disabled-expected.txt: Added.
     47            * fast/css/aspect-ratio-invalidate-if-disabled.html: Added.
     48
    1492021-02-21  Lauro Moura  <lmoura@igalia.com>
    250

  • branches/safari-612.1.5-branch/Source/WebCore/ChangeLog

    r273785 r273791  
     12021-03-02  Alan Coon  <alancoon@apple.com>
     2
     3        Cherry-pick r273314. rdar://problem/74953186
     4
     5    aspect-ratio shows in computed style when disabled
     6    https://bugs.webkit.org/show_bug.cgi?id=222286
     7   
     8    Patch by Rob Buis <rbuis@igalia.com> on 2021-02-23
     9    Reviewed by Simon Fraser.
     10   
     11    Source/WebCore:
     12   
     13    Make aspect-ratio invisible from style when disabled.
     14   
     15    Test: fast/css/aspect-ratio-invalidate-if-disabled.html
     16   
     17    * css/CSSComputedStyleDeclaration.cpp:
     18    (WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
     19    * css/CSSProperties.json:
     20   
     21    Tools:
     22   
     23    Add support for disabling aspect-ratio in wk1.
     24   
     25    * DumpRenderTree/TestOptions.cpp:
     26    (WTR::TestOptions::defaults):
     27   
     28    LayoutTests:
     29   
     30    Add test.
     31   
     32    * fast/css/aspect-ratio-invalidate-if-disabled-expected.txt: Added.
     33    * fast/css/aspect-ratio-invalidate-if-disabled.html: Added.
     34   
     35    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273314 268f45cc-cd09-0410-ab3c-d52691b4dbfc
     36
     37    2021-02-23  Rob Buis  <rbuis@igalia.com>
     38
     39            aspect-ratio shows in computed style when disabled
     40            https://bugs.webkit.org/show_bug.cgi?id=222286
     41
     42            Reviewed by Simon Fraser.
     43
     44            Make aspect-ratio invisible from style when disabled.
     45
     46            Test: fast/css/aspect-ratio-invalidate-if-disabled.html
     47
     48            * css/CSSComputedStyleDeclaration.cpp:
     49            (WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
     50            * css/CSSProperties.json:
     51
    1522021-03-02  Alan Coon  <alancoon@apple.com>
    253

  • branches/safari-612.1.5-branch/Source/WebCore/css/CSSComputedStyleDeclaration.cpp

    r272998 r273791  
    34623462            return cssValuePool.createValue(style.appearance());
    34633463        case CSSPropertyAspectRatio:
     3464            if (renderer && !renderer->settings().aspectRatioEnabled())
     3465                return nullptr;
    34643466            switch (style.aspectRatioType()) {
    34653467            case AspectRatioType::Auto:

  • branches/safari-612.1.5-branch/Source/WebCore/css/CSSProperties.json

    r272987 r273791  
    45574557        "aspect-ratio": {
    45584558            "codegen-properties": {
    4559                 "custom": "All"
     4559                "custom": "All",
     4560                "settings-flag": "aspectRatio"
    45604561            },
    45614562            "status": {

  • branches/safari-612.1.5-branch/Tools/ChangeLog

    r273427 r273791  
     12021-03-02  Alan Coon  <alancoon@apple.com>
     2
     3        Cherry-pick r273314. rdar://problem/74953186
     4
     5    aspect-ratio shows in computed style when disabled
     6    https://bugs.webkit.org/show_bug.cgi?id=222286
     7   
     8    Patch by Rob Buis <rbuis@igalia.com> on 2021-02-23
     9    Reviewed by Simon Fraser.
     10   
     11    Source/WebCore:
     12   
     13    Make aspect-ratio invisible from style when disabled.
     14   
     15    Test: fast/css/aspect-ratio-invalidate-if-disabled.html
     16   
     17    * css/CSSComputedStyleDeclaration.cpp:
     18    (WebCore::ComputedStyleExtractor::valueForPropertyInStyle):
     19    * css/CSSProperties.json:
     20   
     21    Tools:
     22   
     23    Add support for disabling aspect-ratio in wk1.
     24   
     25    * DumpRenderTree/TestOptions.cpp:
     26    (WTR::TestOptions::defaults):
     27   
     28    LayoutTests:
     29   
     30    Add test.
     31   
     32    * fast/css/aspect-ratio-invalidate-if-disabled-expected.txt: Added.
     33    * fast/css/aspect-ratio-invalidate-if-disabled.html: Added.
     34   
     35    git-svn-id: https://svn.webkit.org/repository/webkit/trunk@273314 268f45cc-cd09-0410-ab3c-d52691b4dbfc
     36
     37    2021-02-23  Rob Buis  <rbuis@igalia.com>
     38
     39            aspect-ratio shows in computed style when disabled
     40            https://bugs.webkit.org/show_bug.cgi?id=222286
     41
     42            Reviewed by Simon Fraser.
     43
     44            Add support for disabling aspect-ratio in wk1.
     45
     46            * DumpRenderTree/TestOptions.cpp:
     47            (WTR::TestOptions::defaults):
     48
    1492021-02-24  Russell Epstein  <repstein@apple.com>
    250

  • branches/safari-612.1.5-branch/Tools/DumpRenderTree/TestOptions.cpp

    r270613 r273791  
    7272            { "AllowUniversalAccessFromFileURLs", true },
    7373            { "AspectRatioOfImgFromWidthAndHeightEnabled", false },
     74            { "AspectRatioEnabled", true },
    7475            { "AsyncClipboardAPIEnabled", false },
    7576            { "AttachmentElementEnabled", false },
Note: See TracChangeset for help on using the changeset viewer.