Changeset 274208 in webkit

Timestamp:

Mar 10, 2021, 3:56:00 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, reverting r274166.
​https://bugs.webkit.org/show_bug.cgi?id=223024

Broke GTK Debug builds

Reverted changeset:

"[GTK] Reenable -fvisibility=hidden"
​https://bugs.webkit.org/show_bug.cgi?id=181916
​https://trac.webkit.org/changeset/274166

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/PlatformGTK.cmake (modified) (1 diff)
• Source/WebCore/dom/EventTarget.cpp (modified) (1 diff)
• Source/WebCore/dom/EventTarget.h (modified) (1 diff)
• Source/cmake/OptionsGTK.cmake (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/PlatformGTK.cmake (modified) (1 diff)
• Tools/TestWebKitAPI/glib/TestExpectations.json (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2021-03-10  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, reverting r274166.
+        https://bugs.webkit.org/show_bug.cgi?id=223024
+
+        Broke GTK Debug builds
+
+        Reverted changeset:
+
+        "[GTK] Reenable -fvisibility=hidden"
+        https://bugs.webkit.org/show_bug.cgi?id=181916
+        https://trac.webkit.org/changeset/274166
+
 2021-03-09  Don Olmstead  <don.olmstead@sony.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-03-10  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, reverting r274166.
+        https://bugs.webkit.org/show_bug.cgi?id=223024
+
+        Broke GTK Debug builds
+
+        Reverted changeset:
+
+        "[GTK] Reenable -fvisibility=hidden"
+        https://bugs.webkit.org/show_bug.cgi?id=181916
+        https://trac.webkit.org/changeset/274166
+
 2021-03-10  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/PlatformGTK.cmake

@@ -8 +8 @@
 
 set(WebCore_OUTPUT_NAME WebCoreGTK)
+
+# FIXME: https://bugs.webkit.org/show_bug.cgi?id=181916
+# Remove these lines when turning on hidden visibility
+list(APPEND WebCore_PRIVATE_LIBRARIES WebKit::WTF)
+if (NOT USE_SYSTEM_MALLOC)
+    list(APPEND WebCore_PRIVATE_LIBRARIES WebKit::bmalloc)
+endif ()
 
 list(APPEND WebCore_UNIFIED_SOURCE_LIST_FILES

trunk/Source/WebCore/dom/EventTarget.cpp

@@ -67 +67 @@
 }
 
-EventTarget::~EventTarget() = default;
-
 bool EventTarget::isNode() const
 {

trunk/Source/WebCore/dom/EventTarget.h

@@ -104 +104 @@
 
 protected:
-    WEBCORE_EXPORT virtual ~EventTarget();
+    virtual ~EventTarget() = default;
     
     virtual EventTargetData* eventTargetData() = 0;

trunk/Source/cmake/OptionsGTK.cmake

@@ -18 +18 @@
 
 CALCULATE_LIBRARY_VERSIONS_FROM_LIBTOOL_TRIPLE(JAVASCRIPTCORE 37 0 19)
-
-set(CMAKE_C_VISIBILITY_PRESET hidden)
-set(CMAKE_CXX_VISIBILITY_PRESET hidden)
-set(bmalloc_LIBRARY_TYPE OBJECT)
-set(WTF_LIBRARY_TYPE OBJECT)
 
 # These are shared variables, but we special case their definition so that we can use the

trunk/Tools/ChangeLog

@@ +1 @@
+2021-03-10  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, reverting r274166.
+        https://bugs.webkit.org/show_bug.cgi?id=223024
+
+        Broke GTK Debug builds
+
+        Reverted changeset:
+
+        "[GTK] Reenable -fvisibility=hidden"
+        https://bugs.webkit.org/show_bug.cgi?id=181916
+        https://trac.webkit.org/changeset/274166
+
 2021-03-09  Don Olmstead  <don.olmstead@sony.com>
 

trunk/Tools/TestWebKitAPI/PlatformGTK.cmake

@@ -28 +28 @@
     GTK::GTK
 )
+
+# FIXME: Remove when turning on hidden visibility https://bugs.webkit.org/show_bug.cgi?id=181916
+list(APPEND TestJavaScriptCore_LIBRARIES WTF)
 
 # TestWebCore

trunk/Tools/TestWebKitAPI/glib/TestExpectations.json

@@ -295 +295 @@
             "/jsc/vm": {
                 "expected": {"all": {"slow": true}}
-            },
-            "/jsc/weak-value": {
-                "expected": {"all": {"status": ["FAIL", "PASS"], "bug": "webkit.org/b/222972"}}
             }
         }