Changeset 274229 in webkit

Timestamp:

Mar 10, 2021, 12:36:30 PM (6 years ago)

Author:

Razvan Caliman

Message:

Web Inspector: CSS Grid Inspector clean-up
​https://bugs.webkit.org/show_bug.cgi?id=222913
<rdar://problem/75171301>

Reviewed by BJ Burg.

Remove obsolete methods to show/hide the grid overlay directly from a DOMNode.
Remove engineering-only context menu helpers used while implementing grid overlays.

• UserInterface/Models/DOMNode.js:
• UserInterface/Views/ContextMenuUtilities.js:

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• UserInterface/Models/DOMNode.js (modified) (1 diff)
• UserInterface/Views/ContextMenuUtilities.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2021-03-10  Razvan Caliman  <rcaliman@apple.com>
+
+        Web Inspector: CSS Grid Inspector clean-up
+        https://bugs.webkit.org/show_bug.cgi?id=222913
+        <rdar://problem/75171301>
+
+        Reviewed by BJ Burg.
+
+        Remove obsolete methods to show/hide the grid overlay directly from a DOMNode.
+        Remove engineering-only context menu helpers used while implementing grid overlays.
+
+        * UserInterface/Models/DOMNode.js:
+        * UserInterface/Views/ContextMenuUtilities.js:
+
 2021-03-09  Razvan Caliman  <rcaliman@apple.com>
 

trunk/Source/WebInspectorUI/UserInterface/Models/DOMNode.js

@@ -573 +573 @@
         let target = WI.assumingMainTarget();
         target.DOMAgent.highlightNode(WI.DOMManager.buildHighlightConfig(mode), this.id);
-    }
-
-    showGridOverlay(color, {showLineNames, showLineNumbers, showExtendedGridLines, showTrackSizes, showAreaNames} = {})
-    {
-        console.assert(color instanceof WI.Color, color);
-
-        if (this._destroyed)
-            return Promise.reject("Cannot show overlay, node is destroyed");
-
-        let target = WI.assumingMainTarget();
-        return target.DOMAgent.showGridOverlay.invoke({
-            nodeId: this.id,
-            gridColor: color.toProtocol(),
-            showLineNames: !!showLineNames,
-            showLineNumbers: !!showLineNumbers,
-            showExtendedGridLines: !!showExtendedGridLines,
-            showTrackSizes: !!showTrackSizes,
-            showAreaNames: !!showAreaNames,
-        });
-    }
-
-    hideGridOverlay()
-    {
-        if (this._destroyed)
-            return Promise.reject("Cannot hide overlay, node is destroyed");
-
-        let target = WI.assumingMainTarget();
-        return target.DOMAgent.hideGridOverlay(this.id);
     }
 

trunk/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js

@@ -387 +387 @@
 
         contextMenu.appendSeparator();
-
-        // FIXME: <https://webkit.org/b/221246> remove these engineering-only menu items when removing the feature flag.
-        if (WI.isEngineeringBuild && WI.settings.experimentalEnableLayoutPanel.value) {
-            if (InspectorBackend.hasCommand("DOM.showGridOverlay") && attached) {
-                contextMenu.appendItem(WI.unlocalizedString("Add Grid Overlay with Random Color"), () => {
-                    let randomComponent = () => Math.floor(Math.random() * 255);
-                    let color = new WI.Color(WI.Color.Format.RGB, [randomComponent(), randomComponent(), randomComponent()]);
-                    domNode.showGridOverlay(color).catch(console.error);
-                });
-
-                contextMenu.appendItem(WI.unlocalizedString("Remove Grid Overlay for this Node"), () => {
-                    domNode.hideGridOverlay();
-                });
-
-                contextMenu.appendItem(WI.unlocalizedString("Remove All Grid Overlays"), () => {
-                    let target = WI.assumingMainTarget();
-                    target.DOMAgent.hideGridOverlay();
-                });
-            }
-        }
-
-        contextMenu.appendSeparator();
     }
 };