Changeset 274233 in webkit

Timestamp:

Mar 10, 2021, 1:20:41 PM (6 years ago)

Author:

Adrian Perez de Castro

Message:

[WPE][GTK] Running Tools/gtk/install-dependencies installs too many packages on Debian/Ubuntu
​https://bugs.webkit.org/show_bug.cgi?id=223036

Reviewed by Don Olmstead.

Avoid installing unneeded packages by passing --no-install-recommends to apt-get
invocations. While at it, also make sure to always pass -y to make the installation
non-interactive.

• gtk/install-dependencies:
• wpe/install-dependencies:

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• gtk/install-dependencies (modified) (1 diff)
• wpe/install-dependencies (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2021-03-10  Adrian Perez de Castro  <aperez@igalia.com>
+
+        [WPE][GTK] Running Tools/gtk/install-dependencies installs too many packages on Debian/Ubuntu
+        https://bugs.webkit.org/show_bug.cgi?id=223036
+
+        Reviewed by Don Olmstead.
+
+        Avoid installing unneeded packages by passing --no-install-recommends to apt-get
+        invocations. While at it, also make sure to always pass -y to make the installation
+        non-interactive.
+
+        * gtk/install-dependencies:
+        * wpe/install-dependencies:
+
 2021-03-10  Brent Fulgham  <bfulgham@apple.com>
 

trunk/Tools/gtk/install-dependencies

@@ -260 +260 @@
         gstreamer1.0-pulseaudio"
 
-    apt-get install $packages
+    apt-get install -y --no-install-recommends $packages
 
     # Ubuntu Bionic doesn't ship pipenv. So fallback to the pip3 install path.
     if apt-cache show pipenv &>/dev/null; then
-        apt-get install pipenv
+        apt-get install -y --no-install-recommends pipenv
     else
-        apt-get install -y python3-pip
+        apt-get install -y --no-install-recommends python3-pip
         pip3 install pipenv
     fi

trunk/Tools/wpe/install-dependencies

@@ -163 +163 @@
         gstreamer1.0-pulseaudio"
 
-    apt-get install $packages
+    apt-get install -y --no-install-recommends $packages
 
     # Ubuntu Bionic doesn't ship pipenv. So fallback to the pip3 install path.
     if apt-cache show pipenv &>/dev/null; then
-        apt-get install pipenv
+        apt-get install -y --no-install-recommends pipenv
     else
-        apt-get install -y python3-pip
+        apt-get install -y --no-install-recommends python3-pip
         pip3 install pipenv
     fi