Changeset 274478 in webkit

Timestamp:

Mar 16, 2021, 8:04:10 AM (6 years ago)

Author:

calvaris@igalia.com

Message:

[GStreamer][MSE] fix video freeze in NASA TV feed
​https://bugs.webkit.org/show_bug.cgi?id=214625

Reviewed by Alicia Boya Garcia.

Initial seek should not be marked as a real seek as it is not
getting seek-datas from GStreamer and therefore it can mess up
with pipeline branches becoming empty after getting an enough-data
because the need-data is expecting seek-datas to complete that
seek that is never going to happen.

A couple of debug output lines were fixed for the same price.

• platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:

(webKitMediaSrcPrepareInitialSeek):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp (modified) (3 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-03-16  Xabier Rodriguez Calvar  <calvaris@igalia.com>
+
+        [GStreamer][MSE] fix video freeze in NASA TV feed
+        https://bugs.webkit.org/show_bug.cgi?id=214625
+
+        Reviewed by Alicia Boya Garcia.
+
+        Initial seek should not be marked as a real seek as it is not
+        getting seek-datas from GStreamer and therefore it can mess up
+        with pipeline branches becoming empty after getting an enough-data
+        because the need-data is expecting seek-datas to complete that
+        seek that is never going to happen.
+
+        A couple of debug output lines were fixed for the same price.
+
+        * platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp:
+        (webKitMediaSrcPrepareInitialSeek):
+
 2021-03-16  Ziran Sun  <zsun@igalia.com>
 

trunk/Source/WebCore/platform/graphics/gstreamer/mse/WebKitMediaSourceGStreamer.cpp

@@ -103 +103 @@
         int numAppsrcs = webKitMediaSrc->priv->streams.size();
         if (webKitMediaSrc->priv->appsrcSeekDataCount == numAppsrcs && webKitMediaSrc->priv->appsrcNeedDataCount == numAppsrcs) {
-            GST_DEBUG("All needDatas completed");
+            GST_DEBUG_OBJECT(webKitMediaSrc, "All needDatas completed");
             allAppsrcNeedDataAfterSeek = true;
             webKitMediaSrc->priv->appsrcSeekDataCount = 0;
@@ -116 +116 @@
 
     if (allAppsrcNeedDataAfterSeek) {
-        GST_DEBUG("All expected appsrcSeekData() and appsrcNeedData() calls performed. Running next action (%d)", static_cast<int>(appsrcSeekDataNextAction));
+        GST_DEBUG_OBJECT(webKitMediaSrc, "All expected appsrcSeekData() and appsrcNeedData() calls performed. Running next action (%d)", static_cast<int>(appsrcSeekDataNextAction));
 
         switch (appsrcSeekDataNextAction) {
@@ -759 +759 @@
 
     // The pending action will be performed in enabledAppsrcSeekData().
-    source->priv->appsrcSeekDataNextAction = MediaSourceSeekToTime;
+    source->priv->appsrcSeekDataNextAction = Nothing;
 
     GUniquePtr<GstSegment> segment(gst_segment_new());