Changeset 274499 in webkit

Timestamp:

Mar 16, 2021, 11:35:16 AM (6 years ago)

Author:

Antti Koivisto

Message:

[WebView _touchEventRegions] needs to take the web lock
​https://bugs.webkit.org/show_bug.cgi?id=223266

Reviewed by Simon Fraser.

Clicking anything in UIWebView test app in debug build hits thread assert immediately.

• WebView/WebView.mm:

(-[WebView _touchEventRegions]):

Location:

trunk/Source/WebKitLegacy/mac

Files:

• ChangeLog (modified) (1 diff)
• WebView/WebView.mm (modified) (1 diff)

trunk/Source/WebKitLegacy/mac/ChangeLog

@@ +1 @@
+2021-03-16  Antti Koivisto  <antti@apple.com>
+
+        [WebView _touchEventRegions] needs to take the web lock
+        https://bugs.webkit.org/show_bug.cgi?id=223266
+
+        Reviewed by Simon Fraser.
+
+        Clicking anything in UIWebView test app in debug build hits thread assert immediately.
+
+        * WebView/WebView.mm:
+        (-[WebView _touchEventRegions]):
+
 2021-03-11  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKitLegacy/mac/WebView/WebView.mm

@@ -4023 +4023 @@
 - (NSArray *)_touchEventRegions
 {
+#if PLATFORM(IOS_FAMILY)
+    WebThreadLock();
+#endif
+    
     auto* frame = [self _mainCoreFrame];
     if (!frame)