Changeset 274714 in webkit

Timestamp:

Mar 19, 2021, 6:58:03 AM (6 years ago)

Author:

pvollan@apple.com

Message:

[Win] Fix build issue
​https://bugs.webkit.org/show_bug.cgi?id=223451
<rdar://75545172>

Reviewed by Brent Fulgham.

Source/WebKitLegacy:

Specify that WebKitLegacy links WebCore and PAL statically, since the correctness of the WEBCORE_EXPORT macro depends on that.

• PlatformWin.cmake:

Source/WebKitLegacy/win:

Add WebCore namespace to function call.

• Plugins/PluginView.cpp:

(WebCore::PluginView::getValueForURL):

Location:

trunk/Source/WebKitLegacy

Files:

• ChangeLog (modified) (1 diff)
• PlatformWin.cmake (modified) (1 diff)
• win/ChangeLog (modified) (1 diff)
• win/Plugins/PluginView.cpp (modified) (1 diff)

trunk/Source/WebKitLegacy/ChangeLog

@@ +1 @@
+2021-03-19  Per Arne  <pvollan@apple.com>
+
+        [Win] Fix build issue
+        https://bugs.webkit.org/show_bug.cgi?id=223451
+        <rdar://75545172>
+
+        Reviewed by Brent Fulgham.
+
+        Specify that WebKitLegacy links WebCore and PAL statically, since the correctness of the WEBCORE_EXPORT macro depends on that.
+
+        * PlatformWin.cmake:
+
 2021-03-11  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKitLegacy/PlatformWin.cmake

@@ -523 +523 @@
     WebKit${DEBUG_SUFFIX}
 )
+
+list(APPEND WebKitLegacy_PRIVATE_DEFINITIONS
+    STATICALLY_LINKED_WITH_PAL
+    STATICALLY_LINKED_WITH_WebCore
+)

trunk/Source/WebKitLegacy/win/ChangeLog

@@ +1 @@
+2021-03-19  Per Arne  <pvollan@apple.com>
+
+        [Win] Fix build issue
+        https://bugs.webkit.org/show_bug.cgi?id=223451
+        <rdar://75545172>
+
+        Reviewed by Brent Fulgham.
+
+        Add WebCore namespace to function call.
+
+        * Plugins/PluginView.cpp:
+        (WebCore::PluginView::getValueForURL):
+
 2021-03-14  Fujii Hironori  <Hironori.Fujii@sony.com>
 

trunk/Source/WebKitLegacy/win/Plugins/PluginView.cpp

@@ -1296 +1296 @@
         URL u(m_parentFrame->document()->baseURL(), url);
         if (u.isValid()) {
-            const CString proxyStr = toString(proxyServersForURL(u)).utf8();
+            const CString proxyStr = toString(WebCore::proxyServersForURL(u)).utf8();
             if (!proxyStr.isNull()) {
                 const int size = proxyStr.length();