Changeset 274723 in webkit

Timestamp:

Mar 19, 2021, 9:35:43 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Protect frame before calling didBeginDocument
​https://bugs.webkit.org/show_bug.cgi?id=217185

Patch by Rob Buis <​rbuis@igalia.com> on 2021-03-19
Reviewed by Alex Christensen.

Protect frame before calling didBeginDocument
since it could potentially delete the frame
through event handling.

• loader/DocumentWriter.cpp:

(WebCore::DocumentWriter::begin):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• loader/DocumentWriter.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-03-19  Rob Buis  <rbuis@igalia.com>
+
+        Protect frame before calling didBeginDocument
+        https://bugs.webkit.org/show_bug.cgi?id=217185
+
+        Reviewed by Alex Christensen.
+
+        Protect frame before calling didBeginDocument
+        since it could potentially delete the frame
+        through event handling.
+
+        * loader/DocumentWriter.cpp:
+        (WebCore::DocumentWriter::begin):
+
 2021-03-19  Xabier Rodriguez Calvar  <calvaris@igalia.com>
 

trunk/Source/WebCore/loader/DocumentWriter.cpp

@@ -193 +193 @@
     }
 
+    auto protectedFrame = makeRef(*m_frame);
+
     m_frame->loader().didBeginDocument(dispatch);