Changeset 27478 in webkit


Ignore:
Timestamp:
Nov 6, 2007, 9:48:56 AM (18 years ago)
Author:
mitz@apple.com
Message:

WebCore:

Reviewed by Darin Adler.

Test: fast/repaint/make-children-non-inline.html

  • rendering/RenderBlock.cpp: (WebCore::RenderBlock::makeChildrenNonInline): Repaint the block. This is needed because the inline children may be repositioned as they move into new anonymous blocks, but those blocks have no knowledge of where their children used to be, so they cannot invalidate those areas.

LayoutTests:

Reviewed by Darin Adler.

  • fast/repaint/make-children-non-inline.html: Added.
  • platform/mac/fast/repaint/make-children-non-inline-expected.txt: Added.
  • platform/mac-leopard/fast/repaint: Added.
  • platform/mac-leopard/fast/repaint/make-children-non-inline-expected.checksum: Added.
  • platform/mac-leopard/fast/repaint/make-children-non-inline-expected.png: Added.
Location:
trunk
Files:
5 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r27464 r27478  
     12007-11-06  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        - repaint test for http://bugs.webkit.org/show_bug.cgi?id=15838
     6          Incomplete repaint toggling "How you know this person" on Facebook
     7
     8        * fast/repaint/make-children-non-inline.html: Added.
     9        * platform/mac/fast/repaint/make-children-non-inline-expected.txt: Added.
     10        * platform/mac-leopard/fast/repaint: Added.
     11        * platform/mac-leopard/fast/repaint/make-children-non-inline-expected.checksum: Added.
     12        * platform/mac-leopard/fast/repaint/make-children-non-inline-expected.png: Added.
     13
    1142007-11-05  Adam Roben  <aroben@apple.com>
    215

  • trunk/WebCore/ChangeLog

    r27477 r27478  
     12007-11-06  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Darin Adler.
     4
     5        - fix http://bugs.webkit.org/show_bug.cgi?id=15838
     6          Incomplete repaint toggling "How you know this person" on Facebook
     7
     8        Test: fast/repaint/make-children-non-inline.html
     9
     10        * rendering/RenderBlock.cpp:
     11        (WebCore::RenderBlock::makeChildrenNonInline): Repaint the block. This
     12        is needed because the inline children may be repositioned as they move
     13        into new anonymous blocks, but those blocks have no knowledge of where
     14        their children used to be, so they cannot invalidate those areas.
     15
    1162007-11-06  Alexey Proskuryakov  <ap@webkit.org>
    217

  • trunk/WebCore/rendering/RenderBlock.cpp

    r27385 r27478  
    289289    m_childrenInline = false;
    290290
     291    RenderObject *child = firstChild();
     292    if (!child)
     293        return;
     294
    291295    deleteLineBoxTree();
    292 
    293     RenderObject *child = firstChild();
    294296
    295297    while (child) {
    … …  
    318320        ASSERT(!c->isInline());
    319321#endif
     322
     323    repaint();
    320324}
    321325
Note: See TracChangeset for help on using the changeset viewer.