Changeset 274824 in webkit

Timestamp:

Mar 22, 2021, 5:18:41 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

[Web Animations] nullptr crash in updatePlaybackRate() with no timeline
​https://bugs.webkit.org/show_bug.cgi?id=223095

Patch by Ian Gilbert <​iang@apple.com> on 2021-03-22
Reviewed by Ryosuke Niwa.

Changed to WebAnimation::remove() to use setTimeline() instead of setTimelineInternal()
to ensure the animation is in the correct play state.

No new tests as this relies on navigating while updating the playback rate and I was unable to make
a reliable test case.

• animation/WebAnimation.cpp:

(WebCore::WebAnimation::remove): Changed setTimelineInternal() to setTimeline() in order to
ensure the animation has the correct play state.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• animation/WebAnimation.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-03-22  Ian Gilbert  <iang@apple.com>
+
+        [Web Animations] nullptr crash in updatePlaybackRate() with no timeline
+        https://bugs.webkit.org/show_bug.cgi?id=223095
+
+        Reviewed by Ryosuke Niwa.
+
+        Changed to WebAnimation::remove() to use setTimeline() instead of setTimelineInternal()
+        to ensure the animation is in the correct play state.
+
+        No new tests as this relies on navigating while updating the playback rate and I was unable to make
+        a reliable test case.
+
+        * animation/WebAnimation.cpp:
+        (WebCore::WebAnimation::remove): Changed setTimelineInternal() to setTimeline() in order to
+        ensure the animation has the correct play state.
+
 2021-03-22  Patrick Angle  <pangle@apple.com>
 

trunk/Source/WebCore/animation/WebAnimation.cpp

@@ -121 +121 @@
     auto protectedThis = makeRef(*this);
     setEffectInternal(nullptr);
-    setTimelineInternal(nullptr);
+    setTimeline(nullptr);
 }