Changeset 27488 in webkit


Ignore:
Timestamp:
Nov 6, 2007 2:28:59 PM (16 years ago)
Author:
justing
Message:

WebCore:

Reviewed by Darin Adler.


<rdar://problem/5576619>
REGRESSION: Caret disappears after deleting the last character in inline hole (15714)

  • editing/TypingCommand.cpp: (WebCore::TypingCommand::deleteSelection): Like the other TypingCommands, including both of the other deletion commands, call typingAddedToOpenCommand(), which takes the command's endingSelection and sets it as selection.

LayoutTests:

Reviewed by Darin Adler.


<rdar://problem/5576619> REGRESSION: Caret disappears after deleting the last character in inline hole (15714)

  • platform/mac/editing/input/5576619-expected.checksum: Added.
  • platform/mac/editing/input/5576619-expected.png: Added.
  • platform/mac/editing/input/5576619-expected.txt: Added.
  • platform/mac/editing/input/5576619.html: Added.
  • platform/mac/editing/input/text-input-controller-expected.txt:
Location:
trunk
Files:
4 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r27486 r27488  
     12007-11-06  Justin Garcia  <justin.garcia@apple.com>
     2
     3        Reviewed by Darin Adler.
     4       
     5        <rdar://problem/5576619> REGRESSION: Caret disappears after deleting the last character in inline hole (15714)
     6
     7        * platform/mac/editing/input/5576619-expected.checksum: Added.
     8        * platform/mac/editing/input/5576619-expected.png: Added.
     9        * platform/mac/editing/input/5576619-expected.txt: Added.
     10        * platform/mac/editing/input/5576619.html: Added.
     11        * platform/mac/editing/input/text-input-controller-expected.txt:
     12
    1132007-11-06  Dan Bernstein  <mitz@apple.com>
    214

  • trunk/LayoutTests/platform/mac/editing/input/text-input-controller-expected.txt

    r27009 r27488  
    2020EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
    2121EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
     22EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
     23EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
     24EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
     25EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    2226EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 0 of #text > DIV > BODY > HTML > #document to 7 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
    2327EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    … …  
    2630EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
    2731EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    28 EDITING DELEGATE: shouldInsertText:Failure replacingDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document givenAction:WebViewInsertActionTyped
     32EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
     33EDITING DELEGATE: shouldInsertText:Success replacingDOMRange:range from 0 of DIV > BODY > HTML > #document to 0 of DIV > BODY > HTML > #document givenAction:WebViewInsertActionTyped
    2934EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    3035EDITING DELEGATE: shouldChangeSelectedDOMRange:(null) toDOMRange:range from 7 of #text > DIV > BODY > HTML > #document to 7 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
    3136EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
    3237EDITING DELEGATE: webViewDidChange:WebViewDidChangeNotification
    33 Failure
     38EDITING DELEGATE: shouldChangeSelectedDOMRange:range from 7 of #text > DIV > BODY > HTML > #document to 7 of #text > DIV > BODY > HTML > #document toDOMRange:range from 0 of #text > DIV > BODY > HTML > #document to 7 of #text > DIV > BODY > HTML > #document affinity:NSSelectionAffinityDownstream stillSelecting:FALSE
     39EDITING DELEGATE: webViewDidChangeSelection:WebViewDidChangeSelectionNotification
     40Success

  • trunk/WebCore/ChangeLog

    r27486 r27488  
     12007-11-06  Justin Garcia  <justin.garcia@apple.com>
     2
     3        Reviewed by Darin Adler.
     4       
     5        <rdar://problem/5576619>
     6        REGRESSION: Caret disappears after deleting the last character in inline hole (15714)
     7
     8        * editing/TypingCommand.cpp:
     9        (WebCore::TypingCommand::deleteSelection): Like the other TypingCommands, including
     10        both of the other deletion commands, call typingAddedToOpenCommand(), which takes
     11        the command's endingSelection and sets it as selection.
     12
    1132007-11-06  Dan Bernstein  <mitz@apple.com>
    214

  • trunk/WebCore/editing/TypingCommand.cpp

    r27009 r27488  
    506506{
    507507    CompositeEditCommand::deleteSelection(smartDelete);
     508    typingAddedToOpenCommand();
    508509}
    509510
Note: See TracChangeset for help on using the changeset viewer.