Changeset 27504 in webkit

Timestamp:

Nov 7, 2007 12:11:58 AM (17 years ago)

Author:

mitz@apple.com

Message:

WebCore:

Reviewed by Brady Eidson.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=15877 REGRESSION: r27486 caused a layout regression at my bank's website

Test: fast/block/float/overhanging-after-height-decrease-offsets.html

• rendering/RenderBlock.cpp: (WebCore::RenderBlock::layoutBlock):

LayoutTests:

Reviewed by Brady Eidson.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=15877 REGRESSION: r27486 caused a layout regression at my bank's website

• fast/block/float/overhanging-after-height-decrease-offsets.html: Added.
• platform/mac-leopard/fast/block/float/overhanging-after-height-decrease-offsets-expected.checksum: Added.
• platform/mac-leopard/fast/block/float/overhanging-after-height-decrease-offsets-expected.png: Added.
• platform/mac/fast/block/float/overhanging-after-height-decrease-offsets-expected.txt: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/block/float/overhanging-after-height-decrease-offsets.html (added)
• LayoutTests/platform/mac-leopard/fast/block/float/overhanging-after-height-decrease-offsets-expected.checksum (added)
• LayoutTests/platform/mac-leopard/fast/block/float/overhanging-after-height-decrease-offsets-expected.png (added)
• LayoutTests/platform/mac/fast/block/float/overhanging-after-height-decrease-offsets-expected.txt (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/rendering/RenderBlock.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-11-07  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Brady Eidson.
+
+        - test for http://bugs.webkit.org/show_bug.cgi?id=15877
+          REGRESSION: r27486 caused a layout regression at my bank's website
+
+        * fast/block/float/overhanging-after-height-decrease-offsets.html: Added.
+        * platform/mac-leopard/fast/block/float/overhanging-after-height-decrease-offsets-expected.checksum: Added.
+        * platform/mac-leopard/fast/block/float/overhanging-after-height-decrease-offsets-expected.png: Added.
+        * platform/mac/fast/block/float/overhanging-after-height-decrease-offsets-expected.txt: Added.
+
 2007-11-06  Adam Roben  <aroben@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-11-07  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Brady Eidson.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=15877
+          REGRESSION: r27486 caused a layout regression at my bank's website
+
+        Test: fast/block/float/overhanging-after-height-decrease-offsets.html
+
+        * rendering/RenderBlock.cpp:
+        (WebCore::RenderBlock::layoutBlock):
+
 2007-11-06  Beth Dakin  <bdakin@apple.com>
 

trunk/WebCore/rendering/RenderBlock.cpp

@@ -604 +604 @@
                     RenderBlock* block = static_cast<RenderBlock*>(child);
                     if (block->floatBottom() + block->yPos() > m_height)
-                        addOverhangingFloats(block, block->xPos(), block->yPos());
+                        addOverhangingFloats(block, -block->xPos(), -block->yPos());
                 }
             }