Changeset 275045 in webkit

Timestamp:

Mar 25, 2021, 10:16:06 AM (5 years ago)

Author:

Chris Dumez

Message:

Drop unnecessary Settings pre-warming in ProcessWarming::prewarmGlobally()
​https://bugs.webkit.org/show_bug.cgi?id=223749

Reviewed by Antti Koivisto.

Drop unnecessary Settings pre-warming in ProcessWarming::prewarmGlobally(). Based on the comment,
it looks like the intention was to prewarm some font families. However, looking at the code, nothing
that gets populated is global and survives the destruction of the Settings object on the next line.
We don't even make any calls to CTFont.

• page/ProcessWarming.cpp:

(WebCore::ProcessWarming::prewarmGlobally):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• page/ProcessWarming.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-03-25  Chris Dumez  <cdumez@apple.com>
+
+        Drop unnecessary Settings pre-warming in ProcessWarming::prewarmGlobally()
+        https://bugs.webkit.org/show_bug.cgi?id=223749
+
+        Reviewed by Antti Koivisto.
+
+        Drop unnecessary Settings pre-warming in ProcessWarming::prewarmGlobally(). Based on the comment,
+        it looks like the intention was to prewarm some font families. However, looking at the code, nothing
+        that gets populated is global and survives the destruction of the Settings object on the next line.
+        We don't even make any calls to CTFont.
+
+        * page/ProcessWarming.cpp:
+        (WebCore::ProcessWarming::prewarmGlobally):
+
 2021-03-25  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebCore/page/ProcessWarming.cpp

@@ -36 +36 @@
 #include "QualifiedName.h"
 #include "SVGNames.h"
-#include "Settings.h"
 #include "TelephoneNumberDetector.h"
 #include "UserAgentStyle.h"
@@ -69 +68 @@
     initializeNames();
     
-    // Initializes default font families.
-    Settings::create(nullptr);
-    
     // Prewarms user agent stylesheet.
     Style::UserAgentStyle::initDefaultStyleSheet();