Changeset 275086 in webkit

Timestamp:

Mar 26, 2021, 2:42:04 AM (5 years ago)

Author:

Carlos Garcia Campos

Message:

Merge r275085 - REGRESSION(r272301): [SOUP] default port attribute when persisting credential information with libsecret
​https://bugs.webkit.org/show_bug.cgi?id=223782

Reviewed by Adrian Perez de Castro.

Use the default port instead of 0 when the URL omits the port.

• platform/network/soup/AuthenticationChallengeSoup.cpp:

(WebCore::protectionSpaceFromSoupAuthAndURL):

Location:

releases/WebKitGTK/webkit-2.32/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/network/soup/AuthenticationChallengeSoup.cpp (modified) (1 diff)

releases/WebKitGTK/webkit-2.32/Source/WebCore/ChangeLog

@@ +1 @@
+2021-03-26  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        REGRESSION(r272301): [SOUP] default port attribute when persisting credential information with libsecret
+        https://bugs.webkit.org/show_bug.cgi?id=223782
+
+        Reviewed by Adrian Perez de Castro.
+
+        Use the default port instead of 0 when the URL omits the port.
+
+        * platform/network/soup/AuthenticationChallengeSoup.cpp:
+        (WebCore::protectionSpaceFromSoupAuthAndURL):
+
 2021-03-26  Alejandro G. Castro  <alex@igalia.com>
 

releases/WebKitGTK/webkit-2.32/Source/WebCore/platform/network/soup/AuthenticationChallengeSoup.cpp

@@ -65 +65 @@
     auto host = url.host();
     auto port = url.port();
+    if (!port)
+        port = defaultPortForProtocol(url.protocol());
 #else
     URL authURL({ }, makeString("http://", soup_auth_get_authority(soupAuth)));