Changeset 275450 in webkit

Timestamp:

Apr 2, 2021, 4:27:29 PM (6 years ago)

Author:

rniwa@webkit.org

Message:

PendingImageBitmap gets created on a stopped script execution context.
​https://bugs.webkit.org/show_bug.cgi?id=223971

Reviewed by Youenn Fablet.

Don't create a PendingImageBitmap in PendingImageBitmap::fetch
if the associated script execution context had already been stoppped.

The new behavior matches of Chrome although it's technically incorrect.

Correcting it to match the spec & Firefox will refactor a larger fix around
how script execution context is used by the threaded loader.

• html/ImageBitmap.cpp:

(WebCore::PendingImageBitmap::fetch):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/ImageBitmap.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-04-02  Ryosuke Niwa  <rniwa@webkit.org>
+
+        PendingImageBitmap gets created on a stopped script execution context.
+        https://bugs.webkit.org/show_bug.cgi?id=223971
+
+        Reviewed by Youenn Fablet.
+
+        Don't create a PendingImageBitmap in PendingImageBitmap::fetch
+        if the associated script execution context had already been stoppped.
+
+        The new behavior matches of Chrome although it's technically incorrect.
+
+        Correcting it to match the spec & Firefox will refactor a larger fix around
+        how script execution context is used by the threaded loader.
+
+        * html/ImageBitmap.cpp:
+        (WebCore::PendingImageBitmap::fetch):
+
 2021-04-02  Alexey Shvayka  <shvaikalesh@gmail.com>
 

trunk/Source/WebCore/html/ImageBitmap.cpp

@@ -641 +641 @@
     static void fetch(ScriptExecutionContext& scriptExecutionContext, RefPtr<Blob>&& blob, ImageBitmapOptions&& options, Optional<IntRect> rect, ImageBitmap::Promise&& promise)
     {
+        if (scriptExecutionContext.activeDOMObjectsAreStopped())
+            return;
         auto pendingImageBitmap = new PendingImageBitmap(scriptExecutionContext, WTFMove(blob), WTFMove(options), WTFMove(rect), WTFMove(promise));
         pendingImageBitmap->start(scriptExecutionContext);