⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 275655 in webkit


Ignore:
Timestamp:
Apr 8, 2021, 1:58:24 AM (6 years ago)
Author:
commit-queue@webkit.org
Message:

Difficult to understand which IPC message caused an ASSERT due to being not handled
​https://bugs.webkit.org/show_bug.cgi?id=224269

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2021-04-08
Reviewed by Chris Dumez.

Add the message name and destination ID to the assertion message about
unhandled IPC message.

  • Scripts/webkit/messages.py:

(generate_message_handler):

  • Scripts/webkit/tests/TestWithIfMessageMessageReceiver.cpp:

(WebKit::TestWithIfMessage::didReceiveMessage):

  • Scripts/webkit/tests/TestWithImageDataMessageReceiver.cpp:

(WebKit::TestWithImageData::didReceiveMessage):
(WebKit::TestWithImageData::didReceiveSyncMessage):

  • Scripts/webkit/tests/TestWithLegacyReceiverMessageReceiver.cpp:

(WebKit::TestWithLegacyReceiver::didReceiveTestWithLegacyReceiverMessage):
(WebKit::TestWithLegacyReceiver::didReceiveSyncTestWithLegacyReceiverMessage):

  • Scripts/webkit/tests/TestWithSemaphoreMessageReceiver.cpp:

(WebKit::TestWithSemaphore::didReceiveMessage):
(WebKit::TestWithSemaphore::didReceiveSyncMessage):

  • Scripts/webkit/tests/TestWithStreamBufferMessageReceiver.cpp:

(WebKit::TestWithStreamBuffer::didReceiveMessage):

  • Scripts/webkit/tests/TestWithStreamMessageReceiver.cpp:

(WebKit::TestWithStream::didReceiveStreamMessage):

  • Scripts/webkit/tests/TestWithSuperclassMessageReceiver.cpp:

(WebKit::TestWithSuperclass::didReceiveSyncMessage):

  • Scripts/webkit/tests/TestWithoutAttributesMessageReceiver.cpp:

(WebKit::TestWithoutAttributes::didReceiveMessage):
(WebKit::TestWithoutAttributes::didReceiveSyncMessage):

Location:
trunk/Source/WebKit
Files:
10 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WebKit/ChangeLog

    r275650 r275655  
     12021-04-08  Kimmo Kinnunen  <kkinnunen@apple.com>
     2
     3        Difficult to understand which IPC message caused an ASSERT due to being not handled
     4        https://bugs.webkit.org/show_bug.cgi?id=224269
     5
     6        Reviewed by Chris Dumez.
     7
     8        Add the message name and destination ID to the assertion message about
     9        unhandled IPC message.
     10
     11        * Scripts/webkit/messages.py:
     12        (generate_message_handler):
     13        * Scripts/webkit/tests/TestWithIfMessageMessageReceiver.cpp:
     14        (WebKit::TestWithIfMessage::didReceiveMessage):
     15        * Scripts/webkit/tests/TestWithImageDataMessageReceiver.cpp:
     16        (WebKit::TestWithImageData::didReceiveMessage):
     17        (WebKit::TestWithImageData::didReceiveSyncMessage):
     18        * Scripts/webkit/tests/TestWithLegacyReceiverMessageReceiver.cpp:
     19        (WebKit::TestWithLegacyReceiver::didReceiveTestWithLegacyReceiverMessage):
     20        (WebKit::TestWithLegacyReceiver::didReceiveSyncTestWithLegacyReceiverMessage):
     21        * Scripts/webkit/tests/TestWithSemaphoreMessageReceiver.cpp:
     22        (WebKit::TestWithSemaphore::didReceiveMessage):
     23        (WebKit::TestWithSemaphore::didReceiveSyncMessage):
     24        * Scripts/webkit/tests/TestWithStreamBufferMessageReceiver.cpp:
     25        (WebKit::TestWithStreamBuffer::didReceiveMessage):
     26        * Scripts/webkit/tests/TestWithStreamMessageReceiver.cpp:
     27        (WebKit::TestWithStream::didReceiveStreamMessage):
     28        * Scripts/webkit/tests/TestWithSuperclassMessageReceiver.cpp:
     29        (WebKit::TestWithSuperclass::didReceiveSyncMessage):
     30        * Scripts/webkit/tests/TestWithoutAttributesMessageReceiver.cpp:
     31        (WebKit::TestWithoutAttributes::didReceiveMessage):
     32        (WebKit::TestWithoutAttributes::didReceiveSyncMessage):
     33
    1342021-04-02  Darin Adler  <darin@apple.com>
    235

  • trunk/Source/WebKit/Scripts/webkit/messages.py

    r275650 r275655  
    950950            result.append('    UNUSED_PARAM(decoder);\n')
    951951            result.append('    UNUSED_PARAM(connection);\n')
    952             result.append('    ASSERT_NOT_REACHED();\n')
     952            result.append('    ASSERT_NOT_REACHED_WITH_MESSAGE("Unhandled stream message %s to %llu", description(decoder.messageName()), decoder.destinationID());\n')
    953953        result.append('}\n')
    954954    elif async_messages or receiver.has_attribute(WANTS_DISPATCH_MESSAGE_ATTRIBUTE) or receiver.has_attribute(WANTS_ASYNC_DISPATCH_MESSAGE_ATTRIBUTE):
    … …  
    969969            result.append('    UNUSED_PARAM(connection);\n')
    970970            result.append('    UNUSED_PARAM(decoder);\n')
    971             result.append('    ASSERT_NOT_REACHED();\n')
     971            result.append('    ASSERT_NOT_REACHED_WITH_MESSAGE("Unhandled message %s to %llu", description(decoder.messageName()), decoder.destinationID());\n')
    972972        result.append('}\n')
    973973
    … …  
    985985        result.append('    UNUSED_PARAM(decoder);\n')
    986986        result.append('    UNUSED_PARAM(replyEncoder);\n')
    987         result.append('    ASSERT_NOT_REACHED();\n')
     987        result.append('    ASSERT_NOT_REACHED_WITH_MESSAGE("Unhandled synchronous message %s to %llu", description(decoder.messageName()), decoder.destinationID());\n')
    988988        result.append('    return false;\n')
    989989        result.append('}\n')

  • trunk/Source/WebKit/Scripts/webkit/tests/TestWithIfMessageMessageReceiver.cpp

    r274189 r275655  
    5151    UNUSED_PARAM(connection);
    5252    UNUSED_PARAM(decoder);
    53     ASSERT_NOT_REACHED();
     53    ASSERT_NOT_REACHED_WITH_MESSAGE("Unhandled message %s to %llu", description(decoder.messageName()), decoder.destinationID());
    5454}
    5555

  • trunk/Source/WebKit/Scripts/webkit/tests/TestWithImageDataMessageReceiver.cpp

    r274189 r275655  
    4343    UNUSED_PARAM(connection);
    4444    UNUSED_PARAM(decoder);
    45     ASSERT_NOT_REACHED();
     45    ASSERT_NOT_REACHED_WITH_MESSAGE("Unhandled message %s to %llu", description(decoder.messageName()), decoder.destinationID());
    4646}
    4747
    … …  
    5454    UNUSED_PARAM(decoder);
    5555    UNUSED_PARAM(replyEncoder);
    56     ASSERT_NOT_REACHED();
     56    ASSERT_NOT_REACHED_WITH_MESSAGE("Unhandled synchronous message %s to %llu", description(decoder.messageName()), decoder.destinationID());
    5757    return false;
    5858}

  • trunk/Source/WebKit/Scripts/webkit/tests/TestWithLegacyReceiverMessageReceiver.cpp

    r274189 r275655  
    132132    UNUSED_PARAM(connection);
    133133    UNUSED_PARAM(decoder);
    134     ASSERT_NOT_REACHED();
     134    ASSERT_NOT_REACHED_WITH_MESSAGE("Unhandled message %s to %llu", description(decoder.messageName()), decoder.destinationID());
    135135}
    136136
    … …  
    155155    UNUSED_PARAM(decoder);
    156156    UNUSED_PARAM(replyEncoder);
    157     ASSERT_NOT_REACHED();
     157    ASSERT_NOT_REACHED_WITH_MESSAGE("Unhandled synchronous message %s to %llu", description(decoder.messageName()), decoder.destinationID());
    158158    return false;
    159159}

  • trunk/Source/WebKit/Scripts/webkit/tests/TestWithSemaphoreMessageReceiver.cpp

    r274189 r275655  
    4040    UNUSED_PARAM(connection);
    4141    UNUSED_PARAM(decoder);
    42     ASSERT_NOT_REACHED();
     42    ASSERT_NOT_REACHED_WITH_MESSAGE("Unhandled message %s to %llu", description(decoder.messageName()), decoder.destinationID());
    4343}
    4444
    … …  
    5151    UNUSED_PARAM(decoder);
    5252    UNUSED_PARAM(replyEncoder);
    53     ASSERT_NOT_REACHED();
     53    ASSERT_NOT_REACHED_WITH_MESSAGE("Unhandled synchronous message %s to %llu", description(decoder.messageName()), decoder.destinationID());
    5454    return false;
    5555}

  • trunk/Source/WebKit/Scripts/webkit/tests/TestWithStreamBufferMessageReceiver.cpp

    r274189 r275655  
    4040    UNUSED_PARAM(connection);
    4141    UNUSED_PARAM(decoder);
    42     ASSERT_NOT_REACHED();
     42    ASSERT_NOT_REACHED_WITH_MESSAGE("Unhandled message %s to %llu", description(decoder.messageName()), decoder.destinationID());
    4343}
    4444

  • trunk/Source/WebKit/Scripts/webkit/tests/TestWithStreamMessageReceiver.cpp

    r274433 r275655  
    5757    UNUSED_PARAM(decoder);
    5858    UNUSED_PARAM(connection);
    59     ASSERT_NOT_REACHED();
     59    ASSERT_NOT_REACHED_WITH_MESSAGE("Unhandled stream message %s to %llu", description(decoder.messageName()), decoder.destinationID());
    6060}
    6161

  • trunk/Source/WebKit/Scripts/webkit/tests/TestWithSuperclassMessageReceiver.cpp

    r274189 r275655  
    201201    UNUSED_PARAM(decoder);
    202202    UNUSED_PARAM(replyEncoder);
    203     ASSERT_NOT_REACHED();
     203    ASSERT_NOT_REACHED_WITH_MESSAGE("Unhandled synchronous message %s to %llu", description(decoder.messageName()), decoder.destinationID());
    204204    return false;
    205205}

  • trunk/Source/WebKit/Scripts/webkit/tests/TestWithoutAttributesMessageReceiver.cpp

    r274189 r275655  
    132132    UNUSED_PARAM(connection);
    133133    UNUSED_PARAM(decoder);
    134     ASSERT_NOT_REACHED();
     134    ASSERT_NOT_REACHED_WITH_MESSAGE("Unhandled message %s to %llu", description(decoder.messageName()), decoder.destinationID());
    135135}
    136136
    … …  
    155155    UNUSED_PARAM(decoder);
    156156    UNUSED_PARAM(replyEncoder);
    157     ASSERT_NOT_REACHED();
     157    ASSERT_NOT_REACHED_WITH_MESSAGE("Unhandled synchronous message %s to %llu", description(decoder.messageName()), decoder.destinationID());
    158158    return false;
    159159}
Note: See TracChangeset for help on using the changeset viewer.