Changeset 275662 in webkit

Timestamp:

Apr 8, 2021, 11:17:31 AM (6 years ago)

Author:

youenn@apple.com

Message:

Broken transition when video player with MediaStream changes size
​https://bugs.webkit.org/show_bug.cgi?id=224161
<rdar://problem/76366061>

Reviewed by Eric Carlson.

In case of animation that changes the root layer bounds, we need to synchronously update
the buffer layer as well.

Manually tested.

• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:

(WebCore::MediaPlayerPrivateMediaStreamAVFObjC::rootLayerBoundsDidChange):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-04-08  Youenn Fablet  <youenn@apple.com>
+
+        Broken transition when video player with MediaStream changes size
+        https://bugs.webkit.org/show_bug.cgi?id=224161
+        <rdar://problem/76366061>
+
+        Reviewed by Eric Carlson.
+
+        In case of animation that changes the root layer bounds, we need to synchronously update
+        the buffer layer as well.
+
+        Manually tested.
+
+        * platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm:
+        (WebCore::MediaPlayerPrivateMediaStreamAVFObjC::rootLayerBoundsDidChange):
+
 2021-04-08  Simon Fraser  <simon.fraser@apple.com>
 

trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaStreamAVFObjC.mm

@@ -1049 +1049 @@
 void MediaPlayerPrivateMediaStreamAVFObjC::rootLayerBoundsDidChange()
 {
-    m_shouldUpdateDisplayLayer = true;
+    auto locker = holdLock(m_sampleBufferDisplayLayerLock);
+    if (m_sampleBufferDisplayLayer)
+        m_sampleBufferDisplayLayer->updateBoundsAndPosition(m_sampleBufferDisplayLayer->rootLayer().bounds, m_videoRotation);
 }