Changeset 275666 in webkit

Timestamp:

Apr 8, 2021, 11:30:02 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

prepare-ChangeLog fails to find deleted functions in files with spaces in their path in Git repositories
​https://bugs.webkit.org/show_bug.cgi?id=224303

Patch by Adam Roben <Adam Roben> on 2021-04-08
Reviewed by Sam Weinig.

It would also print a bunch of errors like this on stderr:

fatal: ambiguous argument 'Foo/Bar.cpp': unknown revision or path not in the working tree.
Use '--' to separate paths from revisions, like this:
'git <command> [<revision>...] -- [<file>...]'

• Scripts/prepare-ChangeLog:

(originalFile): Quote the file path in the git show command we
construct.

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• Scripts/prepare-ChangeLog (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2021-04-08  Adam Roben  <aroben@apple.com>
+
+        prepare-ChangeLog fails to find deleted functions in files with spaces in their path in Git repositories
+        https://bugs.webkit.org/show_bug.cgi?id=224303
+
+        Reviewed by Sam Weinig.
+
+        It would also print a bunch of errors like this on stderr:
+
+            fatal: ambiguous argument 'Foo/Bar.cpp': unknown revision or path not in the working tree.
+            Use '--' to separate paths from revisions, like this:
+            'git <command> [<revision>...] -- [<file>...]'
+
+        * Scripts/prepare-ChangeLog:
+        (originalFile): Quote the file path in the `git show` command we
+        construct.
+
 2021-04-08  Truitt Savell  <tsavell@apple.com>
 

trunk/Tools/Scripts/prepare-ChangeLog

@@ -271 +271 @@
             $command .= "HEAD";
         }
-        $command .= ":$file";
+        $command .= ":'$file'";
     }