Changeset 275669 in webkit

Timestamp:

Apr 8, 2021, 11:47:57 AM (5 years ago)

Author:

Brent Fulgham

Message:

[Cocoa] Temporarily retain some media services when GPU Process active
​https://bugs.webkit.org/show_bug.cgi?id=224328
<rdar://problem/76370805>

Reviewed by Eric Carlson.

Testing of the GPU Process show that access to the CoreMedia routing service is still needed under
some use cases. To prevent user-facing impact, we will allow these connections while the underlying
issues are resolved.

• UIProcess/WebPageProxy.cpp:

(WebKit::temporaryMachServices): Added.
(WebKit::WebPageProxy::creationParameters): Extend access to the set of temporaryMachServices when
the GPU Process is enabled.

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/WebPageProxy.cpp (modified) (2 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-04-08  Brent Fulgham  <bfulgham@apple.com>
+
+        [Cocoa] Temporarily retain some media services when GPU Process active
+        https://bugs.webkit.org/show_bug.cgi?id=224328
+        <rdar://problem/76370805>
+
+        Reviewed by Eric Carlson.
+
+        Testing of the GPU Process show that access to the CoreMedia routing service is still needed under
+        some use cases. To prevent user-facing impact, we will allow these connections while the underlying
+        issues are resolved.
+
+        * UIProcess/WebPageProxy.cpp:
+        (WebKit::temporaryMachServices): Added.
+        (WebKit::WebPageProxy::creationParameters): Extend access to the set of temporaryMachServices when
+        the GPU Process is enabled.
+
 2021-04-08  Wenson Hsieh  <wenson_hsieh@apple.com>
 

trunk/Source/WebKit/UIProcess/WebPageProxy.cpp

@@ -7776 +7776 @@
     return services;
 }
+
+static const Vector<ASCIILiteral>& temporaryMachServices()
+{
+    static const auto services = makeNeverDestroyed(Vector<ASCIILiteral> {
+        "com.apple.coremedia.routingcontext.xpc"_s // Remove after <rdar://76403302> is fixed.
+    });
+    return services;
+}
 #endif
 
@@ -7871 +7879 @@
         parameters.mediaExtensionHandles = SandboxExtension::createHandlesForMachLookup(mediaRelatedMachServices(), WTF::nullopt);
         parameters.mediaIOKitExtensionHandles = SandboxExtension::createHandlesForIOKitClassExtensions(mediaRelatedIOKitClasses(), WTF::nullopt);
+    } else {
+        // FIXME(224327): Remove this else clause once <rdar://76403302> is fixed.
+        parameters.mediaExtensionHandles = SandboxExtension::createHandlesForMachLookup(temporaryMachServices(), WTF::nullopt);
     }