Changeset 27579 in webkit

Timestamp:

Nov 7, 2007, 12:59:00 PM (18 years ago)

Author:

mitz@apple.com

Message:

WebCore:

Reviewed by Dave Hyatt.

• fix ​http://bugs.webkit.org/show_bug.cgi?id=15887 REGRESSION (r27576): Crash in RenderStyle::affectedByHoverRules clicking link on Digg

Test: fast/css/display-none-inline-style-change-crash.html

• dom/Element.cpp: (WebCore::Element::recalcStyle): Fixed the crash by null-checking the current style and removed other checks that are not strictly necessary.

LayoutTests:

Reviewed by Dave Hyatt.

• test for ​http://bugs.webkit.org/show_bug.cgi?id=15887 REGRESSION (r27576): Crash in RenderStyle::affectedByHoverRules clicking link on Digg

• fast/css/display-none-inline-style-change-crash-expected.txt: Added.
• fast/css/display-none-inline-style-change-crash.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/css/display-none-inline-style-change-crash-expected.txt (added)
• LayoutTests/fast/css/display-none-inline-style-change-crash.html (added)
• WebCore/ChangeLog (modified) (1 diff)
• WebCore/dom/Element.cpp (modified) (1 diff)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2007-11-07  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Dave Hyatt.
+
+        - test for http://bugs.webkit.org/show_bug.cgi?id=15887
+          REGRESSION (r27576): Crash in RenderStyle::affectedByHoverRules clicking link on Digg
+
+        * fast/css/display-none-inline-style-change-crash-expected.txt: Added.
+        * fast/css/display-none-inline-style-change-crash.html: Added.
+
 2007-11-07  Dan Bernstein  <mitz@apple.com>
 

trunk/WebCore/ChangeLog

@@ +1 @@
+2007-11-07  Dan Bernstein  <mitz@apple.com>
+
+        Reviewed by Dave Hyatt.
+
+        - fix http://bugs.webkit.org/show_bug.cgi?id=15887
+          REGRESSION (r27576): Crash in RenderStyle::affectedByHoverRules clicking link on Digg
+
+        Test: fast/css/display-none-inline-style-change-crash.html
+
+        * dom/Element.cpp:
+        (WebCore::Element::recalcStyle): Fixed the crash by null-checking
+        the current style and removed other checks that are not strictly
+        necessary.
+
 2007-11-07  Tristan O'Tierney  <tristan@apple.com>
 

trunk/WebCore/dom/Element.cpp

@@ -725 +725 @@
         }
 
-        if (newStyle && change != Force && styleChangeType() != FullStyleChange && document()->usesDescendantRules()) {
+        if (currentStyle && newStyle) {
             // Preserve "affected by" bits that were propagated to us from descendants
             if (currentStyle->affectedByHoverRules())