Changeset 275807 in webkit

Timestamp:

Apr 11, 2021, 7:35:46 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Store InputType in a Ref before calling setValueAsDecimal
​https://bugs.webkit.org/show_bug.cgi?id=223535

Patch by Rob Buis <​rbuis@igalia.com> on 2021-04-11
Reviewed by Ryosuke Niwa.

Store InputType in a Ref before calling setValueAsDecimal.

• html/InputType.cpp:

(WebCore::InputType::applyStep):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• html/InputType.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-04-11  Rob Buis  <rbuis@igalia.com>
+
+        Store InputType in a Ref before calling setValueAsDecimal
+        https://bugs.webkit.org/show_bug.cgi?id=223535
+
+        Reviewed by Ryosuke Niwa.
+
+        Store InputType in a Ref before calling setValueAsDecimal.
+
+        * html/InputType.cpp:
+        (WebCore::InputType::applyStep):
+
 2021-04-10  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/html/InputType.cpp

@@ -931 +931 @@
         newValue = stepRange.maximum();
 
+    auto protectedThis = makeRef(*this);
     auto result = setValueAsDecimal(newValue, eventBehavior);
-    if (result.hasException())
+    if (result.hasException() || !element())
         return result;