⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 275877 in webkit


Ignore:
Timestamp:
Apr 13, 2021, 3:26:17 AM (6 years ago)
Author:
commit-queue@webkit.org
Message:

ASSERTION FAILED: !m_needExceptionCheck in RTCPeerConnection::CertificateParameters
​https://bugs.webkit.org/show_bug.cgi?id=223788

Patch by Frédéric Wang <​fwang@igalia.com> on 2021-04-13
Reviewed by Ryosuke Niwa.

Source/WebCore:

Test: js/dom/missing-exception-check-in-convertNumbers.html

  • bindings/js/JSDOMConvertNumbers.h:

(WebCore::Converter<IDLFloat>::convert): Handle potential exceptions thrown by toNumber.
(WebCore::Converter<IDLDouble>::convert): Ditto.

LayoutTests:

Add regression test.

  • js/dom/missing-exception-check-in-convertNumbers-expected.txt: Added.
  • js/dom/missing-exception-check-in-convertNumbers.html: Added.
  • platform/win/TestExpectations: Skip test on windows since there is no WebRTC support.
Location:
trunk
Files:
2 added
4 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r275874 r275877  
     12021-04-13  Frédéric Wang  <fwang@igalia.com>
     2
     3        ASSERTION FAILED: !m_needExceptionCheck in RTCPeerConnection::CertificateParameters
     4        https://bugs.webkit.org/show_bug.cgi?id=223788
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Add regression test.
     9
     10        * js/dom/missing-exception-check-in-convertNumbers-expected.txt: Added.
     11        * js/dom/missing-exception-check-in-convertNumbers.html: Added.
     12        * platform/win/TestExpectations: Skip test on windows since there is no WebRTC support.
     13
    1142021-04-13  Youenn Fablet  <youenn@apple.com>
    215

  • trunk/LayoutTests/platform/win/TestExpectations

    r275849 r275877  
    36663666http/tests/webrtc [ Skip ]
    36673667http/wpt/webrtc [ Skip ]
     3668js/dom/missing-exception-check-in-convertNumbers.html [ Skip ]
    36683669
    36693670# Resource Timing Metrics not available.

  • trunk/Source/WebCore/ChangeLog

    r275876 r275877  
     12021-04-13  Frédéric Wang  <fwang@igalia.com>
     2
     3        ASSERTION FAILED: !m_needExceptionCheck in RTCPeerConnection::CertificateParameters
     4        https://bugs.webkit.org/show_bug.cgi?id=223788
     5
     6        Reviewed by Ryosuke Niwa.
     7
     8        Test: js/dom/missing-exception-check-in-convertNumbers.html
     9
     10        * bindings/js/JSDOMConvertNumbers.h:
     11        (WebCore::Converter<IDLFloat>::convert): Handle potential exceptions thrown by toNumber.
     12        (WebCore::Converter<IDLDouble>::convert): Ditto.
     13
    1142021-04-13  Rob Buis  <rbuis@igalia.com>
    215

  • trunk/Source/WebCore/bindings/js/JSDOMConvertNumbers.h

    r251425 r275877  
    292292        auto scope = DECLARE_THROW_SCOPE(vm);
    293293        double number = value.toNumber(&lexicalGlobalObject);
     294        RETURN_IF_EXCEPTION(scope, 0.0);
    294295        if (UNLIKELY(!std::isfinite(number)))
    295296            throwNonFiniteTypeError(lexicalGlobalObject, scope);
    … …  
    347348        auto scope = DECLARE_THROW_SCOPE(vm);
    348349        double number = value.toNumber(&lexicalGlobalObject);
     350        RETURN_IF_EXCEPTION(scope, 0.0);
    349351        if (UNLIKELY(!std::isfinite(number)))
    350352            throwNonFiniteTypeError(lexicalGlobalObject, scope);
Note: See TracChangeset for help on using the changeset viewer.