Changeset 275885 in webkit

Timestamp:

Apr 13, 2021, 8:30:48 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

[GTK4] WTR crash in PlatformWebView::dismissAllPopupMenus()
​https://bugs.webkit.org/show_bug.cgi?id=224487

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2021-04-13
Reviewed by Philippe Normand.

This is because we are using a for loop to iterate children that are destroyed. We should not be destroying the
children, though, we should just hide them, since they are owned by the web view.

• WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:

(WTR::PlatformWebView::dismissAllPopupMenus):

Location:

trunk/Tools

Files:

• ChangeLog (modified) (1 diff)
• WebKitTestRunner/gtk/PlatformWebViewGtk.cpp (modified) (1 diff)

trunk/Tools/ChangeLog

@@ +1 @@
+2021-04-13  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        [GTK4] WTR crash in PlatformWebView::dismissAllPopupMenus()
+        https://bugs.webkit.org/show_bug.cgi?id=224487
+
+        Reviewed by Philippe Normand.
+
+        This is because we are using a for loop to iterate children that are destroyed. We should not be destroying the
+        children, though, we should just hide them, since they are owned by the web view.
+
+        * WebKitTestRunner/gtk/PlatformWebViewGtk.cpp:
+        (WTR::PlatformWebView::dismissAllPopupMenus):
+
 2021-04-13  Aakash Jain  <aakash_jain@apple.com>
 

trunk/Tools/WebKitTestRunner/gtk/PlatformWebViewGtk.cpp

@@ -251 +251 @@
     for (auto* child = gtk_widget_get_first_child(GTK_WIDGET(m_view)); child; child = gtk_widget_get_next_sibling(child)) {
         if (GTK_IS_POPOVER(child))
-            gtk_widget_unparent(child);
+            gtk_widget_hide(child);
     }
 #else