⚠ Archived content — this site is no longer maintained.   Current WebKit documentation is at docs.webkit.org.

Changeset 275912 in webkit


Ignore:
Timestamp:
Apr 13, 2021, 2:20:56 PM (5 years ago)
Author:
commit-queue@webkit.org
Message:

Remove support for NPAPI plugins in WebView
​https://bugs.webkit.org/show_bug.cgi?id=224449

Patch by Alex Christensen <​achristensen@webkit.org> on 2021-04-13
Reviewed by Chris Dumez.

Source/WebKitLegacy/mac:

  • WebView/WebPreferences.mm:

(-[WebPreferences setPlugInsEnabled:]):

Source/WTF:

  • Scripts/Preferences/WebPreferences.yaml:

Tools:

Keep them on in tests until we remove the code.

  • DumpRenderTree/TestOptions.cpp:

(WTR::TestOptions::defaults):

Location:
trunk
Files:
6 edited

Legend:

Unmodified
Added
Removed

  • trunk/Source/WTF/ChangeLog

    r275909 r275912  
     12021-04-13  Alex Christensen  <achristensen@webkit.org>
     2
     3        Remove support for NPAPI plugins in WebView
     4        https://bugs.webkit.org/show_bug.cgi?id=224449
     5
     6        Reviewed by Chris Dumez.
     7
     8        * Scripts/Preferences/WebPreferences.yaml:
     9
    1102021-04-13  Chris Dumez  <cdumez@apple.com>
    211

  • trunk/Source/WTF/Scripts/Preferences/WebPreferences.yaml

    r275077 r275912  
    17211721  defaultValue:
    17221722    WebKitLegacy:
    1723       default: true
     1723      default: false
    17241724    WebKit:
    17251725      default: false

  • trunk/Source/WebKitLegacy/mac/ChangeLog

    r275857 r275912  
     12021-04-13  Alex Christensen  <achristensen@webkit.org>
     2
     3        Remove support for NPAPI plugins in WebView
     4        https://bugs.webkit.org/show_bug.cgi?id=224449
     5
     6        Reviewed by Chris Dumez.
     7
     8        * WebView/WebPreferences.mm:
     9        (-[WebPreferences setPlugInsEnabled:]):
     10
    1112021-04-12  Peng Liu  <peng.liu6@apple.com>
    212

  • trunk/Source/WebKitLegacy/mac/WebView/WebPreferences.mm

    r274810 r275912  
    901901- (void)setPlugInsEnabled:(BOOL)flag
    902902{
    903     [self _setBoolValue: flag forKey: WebKitPluginsEnabledPreferenceKey];
     903    if (flag)
     904        RELEASE_LOG_FAULT(Plugins, "Application attempted to enable WebView NPAPI plug ins, which are no longer supported");
    904905}
    905906

  • trunk/Tools/ChangeLog

    r275910 r275912  
     12021-04-13  Alex Christensen  <achristensen@webkit.org>
     2
     3        Remove support for NPAPI plugins in WebView
     4        https://bugs.webkit.org/show_bug.cgi?id=224449
     5
     6        Reviewed by Chris Dumez.
     7
     8        Keep them on in tests until we remove the code.
     9
     10        * DumpRenderTree/TestOptions.cpp:
     11        (WTR::TestOptions::defaults):
     12
    1132021-04-13  Alex Christensen  <achristensen@webkit.org>
    214

  • trunk/Tools/DumpRenderTree/TestOptions.cpp

    r275159 r275912  
    6464    if (features.boolWebPreferenceFeatures.empty()) {
    6565        features.boolWebPreferenceFeatures = {
     66            { "PluginsEnabled", true },
    6667#if PLATFORM(COCOA)
    6768            // These are non-experimental WebPreference values that must always be set as they
    … …  
    155156            { "NeedsStorageAccessFromFileURLsQuirk", false },
    156157            { "OverscrollBehaviorEnabled", true },
    157             { "PluginsEnabled", true },
    158158            { "PrivateClickMeasurementEnabled", false },
    159159            { "RequestIdleCallbackEnabled", false },
Note: See TracChangeset for help on using the changeset viewer.