Changeset 275938 in webkit

Timestamp:

Apr 14, 2021, 2:42:27 AM (6 years ago)

Author:

commit-queue@webkit.org

Message:

Do not reset computed style for element children with display contents style
​https://bugs.webkit.org/show_bug.cgi?id=223794

Patch by Carlos Garcia Campos <​cgarcia@igalia.com> on 2021-04-14
Reviewed by Antti Koivisto.

We were checking hasDisplayContents() was false before calling resetComputedStyle() on the parent, but we don't
check it when iterating the children.

• dom/Element.cpp:

(WebCore::Element::resetComputedStyle):

• style/StyleTreeResolver.cpp:

(WebCore::Style::TreeResolver::resolveComposedTree):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Element.cpp (modified) (2 diffs)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-04-14  Carlos Garcia Campos  <cgarcia@igalia.com>
+
+        Do not reset computed style for element children with display contents style
+        https://bugs.webkit.org/show_bug.cgi?id=223794
+
+        Reviewed by Antti Koivisto.
+
+        We were checking hasDisplayContents() was false before calling resetComputedStyle() on the parent, but we don't
+        check it when iterating the children.
+
+        * dom/Element.cpp:
+        (WebCore::Element::resetComputedStyle):
+        * style/StyleTreeResolver.cpp:
+        (WebCore::Style::TreeResolver::resolveComposedTree):
+
 2021-04-13  Rob Buis  <rbuis@igalia.com>
 

trunk/Source/WebCore/dom/Element.cpp

@@ -4242 +4242 @@
 
     auto reset = [](Element& element) {
-        if (!element.hasRareData() || !element.elementRareData()->computedStyle())
-            return;
         if (element.hasCustomStyleResolveCallbacks())
             element.willResetComputedStyle();
@@ -4249 +4247 @@
     };
     reset(*this);
-    for (auto& child : descendantsOfType<Element>(*this))
+    for (auto& child : descendantsOfType<Element>(*this)) {
+        if (!child.hasRareData() || !child.elementRareData()->computedStyle() || child.hasDisplayContents())
+            continue;
         reset(child);
+    }
 }