Changeset 276129 in webkit

Timestamp:

Apr 16, 2021, 2:43:04 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

[CMake] UBSan build fixes
​https://bugs.webkit.org/show_bug.cgi?id=224536

Patch by Philippe Normand <​pnormand@igalia.com> on 2021-04-16
Reviewed by Adrian Perez de Castro.

Synchronize UBSan compiler flags with the ones defined in ubsan.xcconfig.

• Source/cmake/WebKitCompilerFlags.cmake:

Location:

trunk

Files:

• ChangeLog (modified) (1 diff)
• Source/cmake/WebKitCompilerFlags.cmake (modified) (1 diff)

trunk/ChangeLog

@@ +1 @@
+2021-04-16  Philippe Normand  <pnormand@igalia.com>
+
+        [CMake] UBSan build fixes
+        https://bugs.webkit.org/show_bug.cgi?id=224536
+
+        Reviewed by Adrian Perez de Castro.
+
+        Synchronize UBSan compiler flags with the ones defined in ubsan.xcconfig.
+
+        * Source/cmake/WebKitCompilerFlags.cmake:
+
 2021-04-15  Don Olmstead  <don.olmstead@sony.com>
 

trunk/Source/cmake/WebKitCompilerFlags.cmake

@@ -202 +202 @@
 
             elseif (${SANITIZER} MATCHES "undefined")
-                WEBKIT_PREPEND_GLOBAL_COMPILER_FLAGS("-fno-omit-frame-pointer -fno-optimize-sibling-calls")
-                # -fsanitize=vptr is incompatible with -fno-rtti
-                set(SANITIZER_COMPILER_FLAGS "-fsanitize=undefined -frtti ${SANITIZER_COMPILER_FLAGS}")
+                # Please keep these options synchronized with Tools/sanitizer/ubsan.xcconfig
+                WEBKIT_PREPEND_GLOBAL_COMPILER_FLAGS("-fno-omit-frame-pointer -fno-delete-null-pointer-checks -fno-optimize-sibling-calls")
+                # -fsanitize=vptr is disabled because incompatible with -fno-rtti
+                set(SANITIZER_COMPILER_FLAGS "-fsanitize=undefined -fno-sanitize=vptr ${SANITIZER_COMPILER_FLAGS}")
                 set(SANITIZER_LINK_FLAGS "-fsanitize=undefined ${SANITIZER_LINK_FLAGS}")