Changeset 276139 in webkit

Timestamp:

Apr 16, 2021, 9:15:18 AM (5 years ago)

Author:

aakash_jain@apple.com

Message:

[ews] Improve step description when layout-tests step is skipped
​https://bugs.webkit.org/show_bug.cgi?id=224666

Reviewed by Jonathan Bedard.

• CISupport/ews-build/steps.py:

(RunWebKitTests.getResultSummary):

• CISupport/ews-build/steps_unittest.py: Updated unit-tests.

Location:

trunk/Tools

Files:

• CISupport/ews-build/steps.py (modified) (1 diff)
• CISupport/ews-build/steps_unittest.py (modified) (3 diffs)
• ChangeLog (modified) (1 diff)

trunk/Tools/CISupport/ews-build/steps.py

@@ -2271 +2271 @@
             status = ' '.join(self.incorrectLayoutLines)
             return {'step': status}
+        if self.results == SKIPPED:
+            if self.getProperty('fast_commit_queue'):
+                return {'step': 'Skipped layout-tests in fast-cq mode'}
+            return {'step': 'Skipped layout-tests'}
 
         return super(RunWebKitTests, self).getResultSummary()

trunk/Tools/CISupport/ews-build/steps_unittest.py

@@ -1722 +1722 @@
         self.setProperty('configuration', 'debug')
         self.setProperty('fast_commit_queue', True)
-        self.expectOutcome(result=SKIPPED, state_string='layout-tests (skipped)')
+        self.expectOutcome(result=SKIPPED, state_string='Skipped layout-tests in fast-cq mode')
         return self.runStep()
 
@@ -1732 +1732 @@
         self.setProperty('configuration', 'debug')
         self.setProperty('passed_mac_wk2', True)
-        self.expectOutcome(result=SKIPPED, state_string='layout-tests (skipped)')
+        self.expectOutcome(result=SKIPPED, state_string='Skipped layout-tests')
         return self.runStep()
 
@@ -2261 +2261 @@
         self.setProperty('configuration', 'debug')
         self.setProperty('fast_commit_queue', True)
-        self.expectOutcome(result=SKIPPED, state_string='layout-tests (skipped)')
+        self.expectOutcome(result=SKIPPED, state_string='Skipped layout-tests in fast-cq mode')
         return self.runStep()
 

trunk/Tools/ChangeLog

@@ +1 @@
+2021-04-16  Aakash Jain  <aakash_jain@apple.com>
+
+        [ews] Improve step description when layout-tests step is skipped
+        https://bugs.webkit.org/show_bug.cgi?id=224666
+
+        Reviewed by Jonathan Bedard.
+
+        * CISupport/ews-build/steps.py:
+        (RunWebKitTests.getResultSummary):
+        * CISupport/ews-build/steps_unittest.py: Updated unit-tests.
+
 2021-04-16  Manuel Rego Casasnovas  <rego@igalia.com>