Changeset 276176 in webkit

Timestamp:

Apr 16, 2021, 3:50:31 PM (5 years ago)

Author:

Kate Cheney

Message:

Disable app-bound request API tests on specific OS versions
​https://bugs.webkit.org/show_bug.cgi?id=223692
<rdar://problem/75787288>

Reviewed by Brent Fulgham.

Source/WTF:

• wtf/PlatformEnableCocoa.h:

Tools:

These test rely on internal additions only available on certain OS
versions. We should disable them on other versions.

• TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:

Location:

trunk

Files:

• Source/WTF/ChangeLog (modified) (1 diff)
• Source/WTF/wtf/PlatformEnableCocoa.h (modified) (1 diff)
• Tools/ChangeLog (modified) (1 diff)
• Tools/TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm (modified) (1 diff)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2021-04-16  Kate Cheney  <katherine_cheney@apple.com>
+
+        Disable app-bound request API tests on specific OS versions
+        https://bugs.webkit.org/show_bug.cgi?id=223692
+        <rdar://problem/75787288>
+
+        Reviewed by Brent Fulgham.
+
+        * wtf/PlatformEnableCocoa.h:
+
 2021-04-16  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/WTF/wtf/PlatformEnableCocoa.h

@@ -658 +658 @@
 #define ENABLE_NOTIFY_FILTERING 1
 #endif
+
+#if !defined(ENABLE_APP_BOUND_REQUESTS) \
+    && ((PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 120000) \
+    || ((PLATFORM(IOS_FAMILY) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 150000)))
+#define ENABLE_APP_BOUND_REQUESTS 1
+#endif

trunk/Tools/ChangeLog

@@ +1 @@
+2021-04-16  Kate Cheney  <katherine_cheney@apple.com>
+
+        Disable app-bound request API tests on specific OS versions
+        https://bugs.webkit.org/show_bug.cgi?id=223692
+        <rdar://problem/75787288>
+
+        Reviewed by Brent Fulgham.
+
+        These test rely on internal additions only available on certain OS
+        versions. We should disable them on other versions.
+
+        * TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm:
+
 2021-04-16  Alex Christensen  <achristensen@webkit.org>
 

trunk/Tools/TestWebKitAPI/Tests/WebKitCocoa/InAppBrowserPrivacy.mm

@@ -1421 +1421 @@
 #endif // ENABLE(APP_BOUND_DOMAINS)
 
-#if USE(APPLE_INTERNAL_SDK)
+#if USE(APPLE_INTERNAL_SDK) && ENABLE(APP_BOUND_REQUESTS)
 TEST(InAppBrowserPrivacy, AppBoundRequest)
 {