Changeset 276185 in webkit

Timestamp:

Apr 16, 2021, 5:38:02 PM (5 years ago)

Author:

Chris Dumez

Message:

The RemoteRemoteCommandListener destructor should never (re-)launch the GPUProcess
​https://bugs.webkit.org/show_bug.cgi?id=224701

Reviewed by Eric Carlson.

The RemoteRemoteCommandListener destructor should never (re-)launch the GPUProcess,
just to unregister itself. If the GPUProcess is not running, then the
RemoteRemoteCommandListener is not registered.

• WebProcess/GPU/media/RemoteRemoteCommandListener.cpp:

(WebKit::RemoteRemoteCommandListener::~RemoteRemoteCommandListener):
(WebKit::RemoteRemoteCommandListener::gpuProcessConnectionDidClose):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/GPU/media/RemoteRemoteCommandListener.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-04-16  Chris Dumez  <cdumez@apple.com>
+
+        The RemoteRemoteCommandListener destructor should never (re-)launch the GPUProcess
+        https://bugs.webkit.org/show_bug.cgi?id=224701
+
+        Reviewed by Eric Carlson.
+
+        The RemoteRemoteCommandListener destructor should never (re-)launch the GPUProcess,
+        just to unregister itself. If the GPUProcess is not running, then the
+        RemoteRemoteCommandListener is not registered.
+
+        * WebProcess/GPU/media/RemoteRemoteCommandListener.cpp:
+        (WebKit::RemoteRemoteCommandListener::~RemoteRemoteCommandListener):
+        (WebKit::RemoteRemoteCommandListener::gpuProcessConnectionDidClose):
+
 2021-04-16  Jiewen Tan  <jiewen_tan@apple.com>
 

trunk/Source/WebKit/WebProcess/GPU/media/RemoteRemoteCommandListener.cpp

@@ -57 +57 @@
 RemoteRemoteCommandListener::~RemoteRemoteCommandListener()
 {
-    auto& connection = m_process.ensureGPUProcessConnection();
-    connection.messageReceiverMap().removeMessageReceiver(*this);
-    connection.connection().send(Messages::GPUConnectionToWebProcess::ReleaseRemoteCommandListener(m_identifier), 0);
+    if (auto* gpuProcessConnection = m_process.existingGPUProcessConnection()) {
+        gpuProcessConnection->messageReceiverMap().removeMessageReceiver(*this);
+        gpuProcessConnection->connection().send(Messages::GPUConnectionToWebProcess::ReleaseRemoteCommandListener(m_identifier), 0);
+    }
 }
 
 void RemoteRemoteCommandListener::gpuProcessConnectionDidClose(GPUProcessConnection&)
 {
+    // FIXME: Should this relaunch the GPUProcess and re-create the RemoteCommandListener?
 }