Changeset 276203 in webkit

Timestamp:

Apr 17, 2021, 12:02:05 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Don't omit conic gradient starting angle when serializing when starting angle is under 0
​https://bugs.webkit.org/show_bug.cgi?id=224719

Patch by Tim Nguyen <​ntim@apple.com> on 2021-04-17
Reviewed by Ryosuke Niwa.

Updated pre-existing test to cover this case.

Test: LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-image-computed.sub.html

LayoutTests/imported/w3c:

• web-platform-tests/css/css-backgrounds/parsing/background-image-computed.sub-expected.txt:
• web-platform-tests/css/css-backgrounds/parsing/background-image-computed.sub.html:

Source/WebCore:

• css/CSSGradientValue.cpp:

(WebCore::CSSConicGradientValue::customCSSText const):

Location:

trunk

Files:

• LayoutTests/imported/w3c/ChangeLog (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-image-computed.sub-expected.txt (modified) (1 diff)
• LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-image-computed.sub.html (modified) (1 diff)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/css/CSSGradientValue.cpp (modified) (1 diff)

trunk/LayoutTests/imported/w3c/ChangeLog

@@ +1 @@
+2021-04-17  Tim Nguyen  <ntim@apple.com>
+
+        Don't omit conic gradient starting angle when serializing when starting angle is under 0
+        https://bugs.webkit.org/show_bug.cgi?id=224719
+
+        Reviewed by Ryosuke Niwa.
+
+        Updated pre-existing test to cover this case.
+
+        Test: LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-image-computed.sub.html
+
+        * web-platform-tests/css/css-backgrounds/parsing/background-image-computed.sub-expected.txt:
+        * web-platform-tests/css/css-backgrounds/parsing/background-image-computed.sub.html:
+
 2021-04-16  Cameron McCormack  <heycam@apple.com>
 

trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-image-computed.sub-expected.txt

@@ -30 +30 @@
 FAIL Property background-image value 'conic-gradient(from 45deg at 50%, red, blue)' assert_equals: expected "conic-gradient(from 45deg, rgb(255, 0, 0), rgb(0, 0, 255))" but got "conic-gradient(from 45deg, red, blue)"
 FAIL Property background-image value 'conic-gradient(from 45deg at 10px 10px, red, blue)' assert_equals: expected "conic-gradient(from 45deg at 10px 10px, rgb(255, 0, 0), rgb(0, 0, 255))" but got "conic-gradient(from 45deg at 10px 10px, red, blue)"
+PASS Property background-image value 'conic-gradient(from -45deg, rgb(255, 0, 0), rgb(0, 0, 255))'
+FAIL Property background-image value 'conic-gradient(from -45deg at center, red, blue)' assert_equals: expected "conic-gradient(from -45deg, rgb(255, 0, 0), rgb(0, 0, 255))" but got "conic-gradient(from -45deg, red, blue)"
+FAIL Property background-image value 'conic-gradient(from -45deg at 50%, red, blue)' assert_equals: expected "conic-gradient(from -45deg, rgb(255, 0, 0), rgb(0, 0, 255))" but got "conic-gradient(from -45deg, red, blue)"
+FAIL Property background-image value 'conic-gradient(from -45deg at 10px 10px, red, blue)' assert_equals: expected "conic-gradient(from -45deg at 10px 10px, rgb(255, 0, 0), rgb(0, 0, 255))" but got "conic-gradient(from -45deg at 10px 10px, red, blue)"
 

trunk/LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-image-computed.sub.html

@@ -55 +55 @@
 test_computed_value('background-image', 'conic-gradient(from 45deg at 50%, red, blue)', 'conic-gradient(from 45deg, rgb(255, 0, 0), rgb(0, 0, 255))');
 test_computed_value('background-image', 'conic-gradient(from 45deg at 10px 10px, red, blue)', 'conic-gradient(from 45deg at 10px 10px, rgb(255, 0, 0), rgb(0, 0, 255))');
+test_computed_value('background-image', 'conic-gradient(from -45deg, rgb(255, 0, 0), rgb(0, 0, 255))');
+test_computed_value('background-image', 'conic-gradient(from -45deg at center, red, blue)', 'conic-gradient(from -45deg, rgb(255, 0, 0), rgb(0, 0, 255))');
+test_computed_value('background-image', 'conic-gradient(from -45deg at 50%, red, blue)', 'conic-gradient(from -45deg, rgb(255, 0, 0), rgb(0, 0, 255))');
+test_computed_value('background-image', 'conic-gradient(from -45deg at 10px 10px, red, blue)', 'conic-gradient(from -45deg at 10px 10px, rgb(255, 0, 0), rgb(0, 0, 255))');
 </script>
 </body>

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-04-17  Tim Nguyen  <ntim@apple.com>
+
+        Don't omit conic gradient starting angle when serializing when starting angle is under 0
+        https://bugs.webkit.org/show_bug.cgi?id=224719
+
+        Reviewed by Ryosuke Niwa.
+
+        Updated pre-existing test to cover this case.
+
+        Test: LayoutTests/imported/w3c/web-platform-tests/css/css-backgrounds/parsing/background-image-computed.sub.html
+
+        * css/CSSGradientValue.cpp:
+        (WebCore::CSSConicGradientValue::customCSSText const):
+
 2021-04-17  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/css/CSSGradientValue.cpp

@@ -1227 +1227 @@
     bool wroteSomething = false;
 
-    if (m_angle && m_angle->computeDegrees() > 0) {
+    if (m_angle && m_angle->computeDegrees()) {
         result.append("from ", m_angle->cssText());
         wroteSomething = true;