Changeset 276288 in webkit

Timestamp:

Apr 20, 2021, 12:12:26 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

REGRESSION(r224516): Remote WebGL Context is not create due to RemoteRenderingBackend not being created
​https://bugs.webkit.org/show_bug.cgi?id=224751

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2021-04-20
Reviewed by Chris Dumez.

Fix WebGL GPU process after r275922.

RemoteRenderingBackend must be created so that RemoteGraphicsContextGL
can take a reference of it.

Fixes layout test failures when run with --gpu-process.

• WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:

(WebKit::RemoteRenderingBackendProxy::ensureBackendCreated):

• WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
• WebProcess/WebCoreSupport/WebChromeClient.cpp:

(WebKit::WebChromeClient::createGraphicsContextGL const):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp (modified) (1 diff)
• WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h (modified) (1 diff)
• WebProcess/WebCoreSupport/WebChromeClient.cpp (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-04-20  Kimmo Kinnunen  <kkinnunen@apple.com>
+
+        REGRESSION(r224516): Remote WebGL Context is not create due to RemoteRenderingBackend not being created
+        https://bugs.webkit.org/show_bug.cgi?id=224751
+
+        Reviewed by Chris Dumez.
+
+        Fix WebGL GPU process after r275922.
+
+        RemoteRenderingBackend must be created so that RemoteGraphicsContextGL
+        can take a reference of it.
+
+        Fixes layout test failures when run with --gpu-process.
+
+        * WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp:
+        (WebKit::RemoteRenderingBackendProxy::ensureBackendCreated):
+        * WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h:
+        * WebProcess/WebCoreSupport/WebChromeClient.cpp:
+        (WebKit::WebChromeClient::createGraphicsContextGL const):
+
 2021-04-19  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.cpp

@@ -421 +421 @@
 }
 
+RenderingBackendIdentifier RemoteRenderingBackendProxy::ensureBackendCreated()
+{
+    ensureGPUProcessConnection();
+    return renderingBackendIdentifier();
+}
+
 } // namespace WebKit
 

trunk/Source/WebKit/WebProcess/GPU/graphics/RemoteRenderingBackendProxy.h

@@ -111 +111 @@
     RenderingBackendIdentifier renderingBackendIdentifier() const;
 
+    RenderingBackendIdentifier ensureBackendCreated();
+
 private:
     explicit RemoteRenderingBackendProxy(WebPage&);

trunk/Source/WebKit/WebProcess/WebCoreSupport/WebChromeClient.cpp

@@ -940 +940 @@
     UNUSED_VARIABLE(hostWindowDisplayID);
 #if PLATFORM(COCOA) || PLATFORM(WIN)
-    return RemoteGraphicsContextGLProxy::create(attributes, m_page.ensureRemoteRenderingBackendProxy().renderingBackendIdentifier());
+    return RemoteGraphicsContextGLProxy::create(attributes, m_page.ensureRemoteRenderingBackendProxy().ensureBackendCreated());
 #else
     return nullptr;