Changeset 276370 in webkit

Timestamp:

Apr 21, 2021, 10:08:28 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

RenderGeometryMap should know about individual transform properties
​https://bugs.webkit.org/show_bug.cgi?id=224856

Patch by Rob Buis <​rbuis@igalia.com> on 2021-04-21
Reviewed by Simon Fraser.

Source/WebCore:

RenderGeometryMap should know about individual transform properties.

Test: fast/transforms/textarea-individual-transform-properties-crash.html

• rendering/RenderGeometryMap.cpp:

(WebCore::RenderGeometryMap::mapToContainer const):
(WebCore::canMapBetweenRenderersViaLayers):

LayoutTests:

Add test for this.

• fast/transforms/textarea-individual-transform-properties-crash-expected.txt: Added.
• fast/transforms/textarea-individual-transform-properties-crash.html: Added.

Location:

trunk

Files:

• LayoutTests/ChangeLog (modified) (1 diff)
• LayoutTests/fast/transforms/textarea-individual-transform-properties-crash-expected.txt (added)
• LayoutTests/fast/transforms/textarea-individual-transform-properties-crash.html (added)
• Source/WebCore/ChangeLog (modified) (1 diff)
• Source/WebCore/rendering/RenderGeometryMap.cpp (modified) (2 diffs)

trunk/LayoutTests/ChangeLog

@@ +1 @@
+2021-04-21  Rob Buis  <rbuis@igalia.com>
+
+        RenderGeometryMap should know about individual transform properties
+        https://bugs.webkit.org/show_bug.cgi?id=224856
+
+        Reviewed by Simon Fraser.
+
+        Add test for this.
+
+        * fast/transforms/textarea-individual-transform-properties-crash-expected.txt: Added.
+        * fast/transforms/textarea-individual-transform-properties-crash.html: Added.
+
 2021-04-21  Aditya Keerthi  <akeerthi@apple.com>
 

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-04-21  Rob Buis  <rbuis@igalia.com>
+
+        RenderGeometryMap should know about individual transform properties
+        https://bugs.webkit.org/show_bug.cgi?id=224856
+
+        Reviewed by Simon Fraser.
+
+        RenderGeometryMap should know about individual transform properties.
+
+        Test: fast/transforms/textarea-individual-transform-properties-crash.html
+
+        * rendering/RenderGeometryMap.cpp:
+        (WebCore::RenderGeometryMap::mapToContainer const):
+        (WebCore::canMapBetweenRenderersViaLayers):
+
 2021-04-21  Don Olmstead  <don.olmstead@sony.com>
 

trunk/Source/WebCore/rendering/RenderGeometryMap.cpp

@@ -106 +106 @@
     FloatPoint rendererMappedResult = m_mapping.last().m_renderer->localToAbsolute(p, m_mapCoordinatesFlags);
 #endif
-    
+
     if (!hasFixedPositionStep() && !hasTransformStep() && !hasNonUniformStep() && (!container || (m_mapping.size() && container == m_mapping[0].m_renderer))) {
         result = p + roundedIntSize(m_accumulatedOffset);
@@ -155 +155 @@
             return false;
 
-        if (current->hasTransformRelatedProperty() && (current->style().hasTransform() || current->style().hasPerspective()))
+        if (current->hasTransformRelatedProperty() && !current->style().preserves3D())
             return false;