Changeset 276492 in webkit

Timestamp:

Apr 23, 2021, 2:43:09 AM (5 years ago)

Author:

svillar@igalia.com

Message:

Do not set synchronous scrolling for layers without relevant scrolling scopes
​https://bugs.webkit.org/show_bug.cgi?id=221383

Reviewed by Simon Fraser.

Fixed backgrounds could force the layer compositor to set synchronous scrolling because they're slow
to repaint. However that cannot be done if the layer's boxScrollingScope hasn't been previously updated
in RenderLayer::updateLayerPosition.

• rendering/RenderLayerCompositor.cpp:

(WebCore::RenderLayerCompositor::updateSynchronousScrollingNodes): Do not call
setSynchronousScrollingReasons() if there is no scrollingScope.

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• rendering/RenderLayerCompositor.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-04-22  Sergio Villar Senin  <svillar@igalia.com>
+
+        Do not set synchronous scrolling for layers without relevant scrolling scopes
+        https://bugs.webkit.org/show_bug.cgi?id=221383
+
+        Reviewed by Simon Fraser.
+
+        Fixed backgrounds could force the layer compositor to set synchronous scrolling because they're slow
+        to repaint. However that cannot be done if the layer's boxScrollingScope hasn't been previously updated
+        in RenderLayer::updateLayerPosition.
+
+        * rendering/RenderLayerCompositor.cpp:
+        (WebCore::RenderLayerCompositor::updateSynchronousScrollingNodes): Do not call
+        setSynchronousScrollingReasons() if there is no scrollingScope.
+
 2021-04-23  Philippe Normand  <pnormand@igalia.com>
 

trunk/Source/WebCore/rendering/RenderLayerCompositor.cpp

@@ -4949 +4949 @@
             continue;
 
-        auto scrollingScope = relevantScrollingScope(renderer, *layer);
-        if (scrollingScope != rootScrollingScope) {
+        if (auto scrollingScope = relevantScrollingScope(renderer, *layer); scrollingScope && scrollingScope != rootScrollingScope) {
             auto enclosingScrollingNodeID = asyncScrollableContainerNodeID(renderer);
             ASSERT(enclosingScrollingNodeID);