Changeset 276497 in webkit

Timestamp:

Apr 23, 2021, 7:32:36 AM (5 years ago)

Author:

youenn@apple.com

Message:

Handle rotation correctly in WebRTC GPUProcess rendering pipeline
​https://bugs.webkit.org/show_bug.cgi?id=224927
<rdar://76915991>

Reviewed by Eric Carlson.

Source/WebCore:

Add a routine to update the affine transformn of the root layer.
Manually tested.

• platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.h:
• platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:

(WebCore::LocalSampleBufferDisplayLayer::updateRootLayerAffineTransform):

Source/WebKit:

Instead of updating the inner layer, update the root layer.

• GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp:

(WebKit::RemoteSampleBufferDisplayLayer::updateAffineTransform):

Location:

trunk/Source

Files:

• WebCore/ChangeLog (modified) (1 diff)
• WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.h (modified) (1 diff)
• WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-04-23  Youenn Fablet  <youenn@apple.com>
+
+        Handle rotation correctly in WebRTC GPUProcess rendering pipeline
+        https://bugs.webkit.org/show_bug.cgi?id=224927
+        <rdar://76915991>
+
+        Reviewed by Eric Carlson.
+
+        Add a routine to update the affine transformn of the root layer.
+        Manually tested.
+
+        * platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.h:
+        * platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm:
+        (WebCore::LocalSampleBufferDisplayLayer::updateRootLayerAffineTransform):
+
 2021-04-23  Philippe Normand  <pnormand@igalia.com>
 

trunk/Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.h

@@ -61 +61 @@
     enum class ShouldUpdateRootLayer { No, Yes };
     void updateRootLayerBoundsAndPosition(CGRect, MediaSample::VideoRotation, ShouldUpdateRootLayer);
+    void updateRootLayerAffineTransform(CGAffineTransform);
 
     void initialize(bool hideRootLayer, IntSize, CompletionHandler<void(bool didSucceed)>&&) final;

trunk/Source/WebCore/platform/graphics/avfoundation/objc/LocalSampleBufferDisplayLayer.mm

@@ -249 +249 @@
 }
 
+void LocalSampleBufferDisplayLayer::updateRootLayerAffineTransform(CGAffineTransform transform)
+{
+    runWithoutAnimations([&] {
+        m_rootLayer.get().affineTransform = transform;
+    });
+}
+
 void LocalSampleBufferDisplayLayer::updateAffineTransform(CGAffineTransform transform)
 {

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-04-23  Youenn Fablet  <youenn@apple.com>
+
+        Handle rotation correctly in WebRTC GPUProcess rendering pipeline
+        https://bugs.webkit.org/show_bug.cgi?id=224927
+        <rdar://76915991>
+
+        Reviewed by Eric Carlson.
+
+        Instead of updating the inner layer, update the root layer.
+
+        * GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp:
+        (WebKit::RemoteSampleBufferDisplayLayer::updateAffineTransform):
+
 2021-04-23  Carlos Garcia Campos  <cgarcia@igalia.com>
 

trunk/Source/WebKit/GPUProcess/webrtc/RemoteSampleBufferDisplayLayer.cpp

@@ -79 +79 @@
 void RemoteSampleBufferDisplayLayer::updateAffineTransform(CGAffineTransform transform)
 {
-    m_sampleBufferDisplayLayer->updateAffineTransform(transform);
+    m_sampleBufferDisplayLayer->updateRootLayerAffineTransform(transform);
 }