Changeset 276506 in webkit

Timestamp:

Apr 23, 2021, 10:44:03 AM (5 years ago)

Author:

Chris Dumez

Message:

Disable GPUProcess on shipping iOS
​https://bugs.webkit.org/show_bug.cgi?id=224897

Reviewed by Eric Carlson.

Source/WebKit:

• Shared/WebPreferencesDefaultValues.cpp:

(WebKit::defaultUseGPUProcessForCanvasRenderingEnabled):
(WebKit::defaultUseGPUProcessForDOMRenderingEnabled):
(WebKit::defaultUseGPUProcessForMediaEnabled):
(WebKit::defaultUseGPUProcessForWebGLEnabled):
(WebKit::defaultCaptureAudioInGPUProcessEnabled):
(WebKit::defaultCaptureVideoInGPUProcessEnabled):
(WebKit::defaultWebRTCCodecsInGPUProcess):

Source/WTF:

• wtf/PlatformEnableCocoa.h:

Location:

trunk/Source

Files:

• WTF/ChangeLog (modified) (1 diff)
• WTF/wtf/PlatformEnableCocoa.h (modified) (1 diff)
• WebKit/ChangeLog (modified) (1 diff)
• WebKit/Shared/WebPreferencesDefaultValues.cpp (modified) (6 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2021-04-23  Chris Dumez  <cdumez@apple.com>
+
+        Disable GPUProcess on shipping iOS
+        https://bugs.webkit.org/show_bug.cgi?id=224897
+
+        Reviewed by Eric Carlson.
+
+        * wtf/PlatformEnableCocoa.h:
+
 2021-04-22  Lauro Moura  <lmoura@igalia.com>
 

trunk/Source/WTF/wtf/PlatformEnableCocoa.h

@@ -225 +225 @@
 #endif
 
+#if !defined(ENABLE_GPU_PROCESS_BY_DEFAULT)
+#if PLATFORM(MAC) \
+    || ((PLATFORM(IOS) || PLATFORM(MACCATALYST)) && __IPHONE_OS_VERSION_MIN_REQUIRED >= 150000) \
+    || (PLATFORM(WATCHOS) && __WATCH_OS_VERSION_MIN_REQUIRED >= 80000) \
+    || (PLATFORM(APPLETV) && __TV_OS_VERSION_MIN_REQUIRED >= 150000)
+#define ENABLE_GPU_PROCESS_BY_DEFAULT 1
+#endif
+#endif
+
 #if !defined(ENABLE_GPU_DRIVER_PREWARMING) && PLATFORM(MAC) && __MAC_OS_X_VERSION_MIN_REQUIRED >= 101600
 #define ENABLE_GPU_DRIVER_PREWARMING 1

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-04-23  Chris Dumez  <cdumez@apple.com>
+
+        Disable GPUProcess on shipping iOS
+        https://bugs.webkit.org/show_bug.cgi?id=224897
+
+        Reviewed by Eric Carlson.
+
+        * Shared/WebPreferencesDefaultValues.cpp:
+        (WebKit::defaultUseGPUProcessForCanvasRenderingEnabled):
+        (WebKit::defaultUseGPUProcessForDOMRenderingEnabled):
+        (WebKit::defaultUseGPUProcessForMediaEnabled):
+        (WebKit::defaultUseGPUProcessForWebGLEnabled):
+        (WebKit::defaultCaptureAudioInGPUProcessEnabled):
+        (WebKit::defaultCaptureVideoInGPUProcessEnabled):
+        (WebKit::defaultWebRTCCodecsInGPUProcess):
+
 2021-04-23  Youenn Fablet  <youenn@apple.com>
 

trunk/Source/WebKit/Shared/WebPreferencesDefaultValues.cpp

@@ -146 +146 @@
 bool defaultUseGPUProcessForCanvasRenderingEnabled()
 {
-#if HAVE(SYSTEM_FEATURE_FLAGS)
+#if HAVE(SYSTEM_FEATURE_FLAGS) && ENABLE(GPU_PROCESS_BY_DEFAULT)
     return isFeatureFlagEnabled("gpu_process_canvas_rendering");
 #endif
@@ -155 +155 @@
 bool defaultUseGPUProcessForDOMRenderingEnabled()
 {
-#if HAVE(SYSTEM_FEATURE_FLAGS)
+#if HAVE(SYSTEM_FEATURE_FLAGS) && ENABLE(GPU_PROCESS_BY_DEFAULT)
     return isFeatureFlagEnabled("gpu_process_dom_rendering");
 #endif
@@ -164 +164 @@
 bool defaultUseGPUProcessForMediaEnabled()
 {
-#if HAVE(SYSTEM_FEATURE_FLAGS)
+#if HAVE(SYSTEM_FEATURE_FLAGS) && ENABLE(GPU_PROCESS_BY_DEFAULT)
     return isFeatureFlagEnabled("gpu_process_media");
 #endif
@@ -186 +186 @@
 bool defaultCaptureAudioInGPUProcessEnabled()
 {
-#if HAVE(SYSTEM_FEATURE_FLAGS)
+#if HAVE(SYSTEM_FEATURE_FLAGS) && ENABLE(GPU_PROCESS_BY_DEFAULT)
 #if PLATFORM(MAC)
     return isFeatureFlagEnabled("gpu_process_webrtc");
@@ -207 +207 @@
 bool defaultCaptureVideoInGPUProcessEnabled()
 {
-#if HAVE(SYSTEM_FEATURE_FLAGS)
+#if HAVE(SYSTEM_FEATURE_FLAGS) && ENABLE(GPU_PROCESS_BY_DEFAULT)
     return isFeatureFlagEnabled("gpu_process_webrtc");
 #else
@@ -220 +220 @@
 bool defaultWebRTCCodecsInGPUProcess()
 {
-#if HAVE(SYSTEM_FEATURE_FLAGS)
+#if HAVE(SYSTEM_FEATURE_FLAGS) && ENABLE(GPU_PROCESS_BY_DEFAULT)
     return isFeatureFlagEnabled("gpu_process_webrtc");
 #else