Changeset 276509 in webkit

Timestamp:

Apr 23, 2021, 11:57:30 AM (5 years ago)

Author:

Kate Cheney

Message:

Set proper network logging level for full web browsers
​https://bugs.webkit.org/show_bug.cgi?id=224982
<rdar://problem/76903650>

Reviewed by Brent Fulgham.

Full web browsers have different low-level network logging requirements
for ephemeral sessions.

No new tests. There's no automated way to test if network level logs
show up. I tested that logging is correct for web browser and non web
browser apps manually.

• NetworkProcess/cocoa/NetworkSessionCocoa.mm:

(WebKit::configurationForSessionID):
(WebKit::NetworkSessionCocoa::NetworkSessionCocoa):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• NetworkProcess/cocoa/NetworkSessionCocoa.mm (modified) (3 diffs)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-04-23  Kate Cheney  <katherine_cheney@apple.com>
+
+        Set proper network logging level for full web browsers
+        https://bugs.webkit.org/show_bug.cgi?id=224982
+        <rdar://problem/76903650>
+
+        Reviewed by Brent Fulgham.
+
+        Full web browsers have different low-level network logging requirements
+        for ephemeral sessions.
+
+        No new tests. There's no automated way to test if network level logs
+        show up. I tested that logging is correct for web browser and non web
+        browser apps manually.
+
+        * NetworkProcess/cocoa/NetworkSessionCocoa.mm:
+        (WebKit::configurationForSessionID):
+        (WebKit::NetworkSessionCocoa::NetworkSessionCocoa):
+
 2021-04-23  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebKit/NetworkProcess/cocoa/NetworkSessionCocoa.mm

@@ -1029 +1029 @@
 #endif
 
-static NSURLSessionConfiguration *configurationForSessionID(const PAL::SessionID& session)
+static NSURLSessionConfiguration *configurationForSessionID(const PAL::SessionID& session, bool isFullWebBrowser)
 {
 #if HAVE(LOGGING_PRIVACY_LEVEL)
@@ -1039 +1039 @@
         configuration = [NSURLSessionConfiguration ephemeralSessionConfiguration];
 #if HAVE(LOGGING_PRIVACY_LEVEL) && defined(NW_CONTEXT_HAS_PRIVACY_LEVEL_SILENT)
-        loggingPrivacyLevel = nw_context_privacy_level_silent;
+        if (isFullWebBrowser)
+            loggingPrivacyLevel = nw_context_privacy_level_silent;
 #endif
     } else
@@ -1184 +1185 @@
 #endif
 
-    NSURLSessionConfiguration *configuration = configurationForSessionID(m_sessionID);
+    NSURLSessionConfiguration *configuration = configurationForSessionID(m_sessionID, isParentProcessAFullWebBrowser(networkProcess));
 
 #if HAVE(HSTS_STORAGE)