Changeset 27651 in webkit


Ignore:
Timestamp:
Nov 9, 2007, 12:03:17 PM (18 years ago)
Author:
mitz@apple.com
Message:

WebCore:

Reviewed by Antti Koivisto.

  • fix a bug in invisible layer culling: dynamically changing a descendant of an invisible layer to be visible did not work

Test: fast/layers/layer-content-visibility-change.html

  • rendering/RenderLayer.cpp: (WebCore::RenderLayer::setHasVisibleContent): If we got visible content, make sure that our stacking context rebuilds its z-order lists to include us.

LayoutTests:

Reviewed by Antti Koivisto.

  • test that dynamically changing a descendant of an invisible layer to be visible works
  • fast/layers/layer-content-visibility-change.html: Added.
  • platform/mac/fast/layers/layer-content-visibility-change-expected.checksum: Added.
  • platform/mac/fast/layers/layer-content-visibility-change-expected.png: Added.
  • platform/mac/fast/layers/layer-content-visibility-change-expected.txt: Added.
Location:
trunk
Files:
4 added
3 edited

Legend:

Unmodified
Added
Removed

  • trunk/LayoutTests/ChangeLog

    r27649 r27651  
     12007-11-09  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Antti Koivisto.
     4
     5        - test that dynamically changing a descendant of an invisible layer to
     6          be visible works
     7
     8        * fast/layers/layer-content-visibility-change.html: Added.
     9        * platform/mac/fast/layers/layer-content-visibility-change-expected.checksum: Added.
     10        * platform/mac/fast/layers/layer-content-visibility-change-expected.png: Added.
     11        * platform/mac/fast/layers/layer-content-visibility-change-expected.txt: Added.
     12
    1132007-11-09  Beth Dakin  <bdakin@apple.com>
    214

  • trunk/WebCore/ChangeLog

    r27650 r27651  
     12007-11-09  Dan Bernstein  <mitz@apple.com>
     2
     3        Reviewed by Antti Koivisto.
     4
     5        - fix a bug in invisible layer culling: dynamically changing a
     6          descendant of an invisible layer to be visible did not work
     7
     8        Test: fast/layers/layer-content-visibility-change.html
     9
     10        * rendering/RenderLayer.cpp:
     11        (WebCore::RenderLayer::setHasVisibleContent): If we got visible content,
     12        make sure that our stacking context rebuilds its z-order lists to
     13        include us.
     14
    1152007-11-09  David Hyatt  <hyatt@apple.com>
    216

  • trunk/WebCore/rendering/RenderLayer.cpp

    r27585 r27651  
    246246}
    247247
    248 void RenderLayer::setHasVisibleContent(bool b) 
     248void RenderLayer::setHasVisibleContent(bool b)
    249249{
    250250    if (m_hasVisibleContent == b && !m_visibleContentStatusDirty)
    … …  
    255255        m_repaintRect = renderer()->absoluteClippedOverflowRect();
    256256        m_outlineBox = renderer()->absoluteOutlineBox();
     257        if (!isOverflowOnly()) {
     258            if (RenderLayer* sc = stackingContext())
     259                sc->dirtyZOrderLists();
     260        }
    257261    }
    258262    if (parent())
Note: See TracChangeset for help on using the changeset viewer.