Changeset 276522 in webkit

Timestamp:

Apr 23, 2021, 3:04:56 PM (5 years ago)

Author:

Aditya Keerthi

Message:

REGRESSION (r273154): fast/forms/ios/repeatedly-focus-offscreen-select.html is consistently failing
​https://bugs.webkit.org/show_bug.cgi?id=224985
<rdar://problem/77042177>

Reviewed by Wenson Hsieh.

The test is failing after r273154, which made <select> elements present
a UIMenu rather than a popover. The old logic ensured popovers were not
presented when the <select> element was offscreen (see r265117 for more
information on why that behavior was necessary), but the new
presentation omitted that logic.

To achieve the correct behavior, and fix the failing test, <select>
menus should not be presented when the element is offscreen.

• UIProcess/ios/forms/WKFormSelectPicker.mm:

(-[WKSelectPicker controlBeginEditing]):

Location:

trunk/Source/WebKit

Files:

• ChangeLog (modified) (1 diff)
• UIProcess/ios/forms/WKFormSelectPicker.mm (modified) (1 diff)

trunk/Source/WebKit/ChangeLog

@@ +1 @@
+2021-04-23  Aditya Keerthi  <akeerthi@apple.com>
+
+        REGRESSION (r273154): fast/forms/ios/repeatedly-focus-offscreen-select.html is consistently failing
+        https://bugs.webkit.org/show_bug.cgi?id=224985
+        <rdar://problem/77042177>
+
+        Reviewed by Wenson Hsieh.
+
+        The test is failing after r273154, which made <select> elements present
+        a UIMenu rather than a popover. The old logic ensured popovers were not
+        presented when the <select> element was offscreen (see r265117 for more
+        information on why that behavior was necessary), but the new
+        presentation omitted that logic.
+
+        To achieve the correct behavior, and fix the failing test, <select>
+        menus should not be presented when the element is offscreen.
+
+        * UIProcess/ios/forms/WKFormSelectPicker.mm:
+        (-[WKSelectPicker controlBeginEditing]):
+
 2021-04-23  Commit Queue  <commit-queue@webkit.org>
 

trunk/Source/WebKit/UIProcess/ios/forms/WKFormSelectPicker.mm

@@ -502 +502 @@
 - (void)controlBeginEditing
 {
+    // Don't show the menu if the element is entirely offscreen.
+    if (!CGRectIntersectsRect(_view.focusedElementInformation.interactionRect, _view.bounds))
+        return;
+
     [_view startRelinquishingFirstResponderToFocusedElement];