Changeset 276568 in webkit

Timestamp:

Apr 25, 2021, 12:16:23 PM (5 years ago)

Author:

commit-queue@webkit.org

Message:

[Metal ANGLE] Temporarily remove AST validation even for debug builds
​https://bugs.webkit.org/show_bug.cgi?id=224991
rdar://76299178

Patch by John Cunningham <​johncunningham@apple.com> on 2021-04-25
Reviewed by Kenneth Russell.

• src/libANGLE/renderer/metal/ShaderMtl.mm:

(rx::ShaderMtl::compileImplMtl):

Location:

trunk/Source/ThirdParty/ANGLE

Files:

• ChangeLog (modified) (1 diff)
• src/libANGLE/renderer/metal/ShaderMtl.mm (modified) (1 diff)

trunk/Source/ThirdParty/ANGLE/ChangeLog

@@ +1 @@
+2021-04-25  John Cunningham  <johncunningham@apple.com>
+
+        [Metal ANGLE] Temporarily remove AST validation even for debug builds
+        https://bugs.webkit.org/show_bug.cgi?id=224991
+        rdar://76299178
+ 
+        Reviewed by Kenneth Russell.
+
+        * src/libANGLE/renderer/metal/ShaderMtl.mm:
+        (rx::ShaderMtl::compileImplMtl):
+
 2021-04-25  Kyle Piddington  <kpiddington@apple.com>
 

trunk/Source/ThirdParty/ANGLE/src/libANGLE/renderer/metal/ShaderMtl.mm

@@ -86 +86 @@
     ShCompileOptions compileOptions)
 {
-#if defined(ANGLE_ENABLE_ASSERTS)
+// TODO(jcunningham): Remove this workaround once correct fix to move validation to the very end is in place.
+// See: https://bugs.webkit.org/show_bug.cgi?id=224991
+#if defined(ANGLE_ENABLE_ASSERTS) && 0
     compileOptions |= SH_VALIDATE_AST;
 #endif