Changeset 276681 in webkit

Timestamp:

Apr 27, 2021, 5:04:53 PM (5 years ago)

Author:

Patrick Angle

Message:

Web Inspector: Rename "Open in New Tab" context menu item to "Open in New Window"
​https://bugs.webkit.org/show_bug.cgi?id=225125

Reviewed by BJ Burg.

Update the context menu item label, as the "Open in..." context menu item opens the target item in a new window,
not a new tab.

• Localizations/en.lproj/localizedStrings.js:
• UserInterface/Views/ContextMenuUtilities.js:

(WI.appendContextMenuItemsForURL):

Location:

trunk/Source/WebInspectorUI

Files:

• ChangeLog (modified) (1 diff)
• Localizations/en.lproj/localizedStrings.js (modified) (1 diff)
• UserInterface/Views/ContextMenuUtilities.js (modified) (1 diff)

trunk/Source/WebInspectorUI/ChangeLog

@@ +1 @@
+2021-04-27  Patrick Angle  <pangle@apple.com>
+
+        Web Inspector: Rename "Open in New Tab" context menu item to "Open in New Window"
+        https://bugs.webkit.org/show_bug.cgi?id=225125
+
+        Reviewed by BJ Burg.
+
+        Update the context menu item label, as the "Open in..." context menu item opens the target item in a new window,
+        not a new tab.
+
+        * Localizations/en.lproj/localizedStrings.js:
+        * UserInterface/Views/ContextMenuUtilities.js:
+        (WI.appendContextMenuItemsForURL):
+
 2021-04-27  Patrick Angle  <pangle@apple.com>
 

trunk/Source/WebInspectorUI/Localizations/en.lproj/localizedStrings.js

@@ -1022 +1022 @@
 localizedStrings["Only show visual actions"] = "Only show visual actions";
 localizedStrings["Open"] = "Open";
-localizedStrings["Open in New Tab"] = "Open in New Tab";
+/* Context menu item for opening the target item in a new window. */
+localizedStrings["Open in New Window @ Context Menu Item"] = "Open in New Window";
 localizedStrings["Option-click to show source"] = "Option-click to show source";
 localizedStrings["Options"] = "Options";

trunk/Source/WebInspectorUI/UserInterface/Views/ContextMenuUtilities.js

@@ -213 +213 @@
 
     if (!url.startsWith("javascript:") && !url.startsWith("data:")) {
-        contextMenu.appendItem(WI.UIString("Open in New Tab"), () => {
+        contextMenu.appendItem(WI.UIString("Open in New Window", "Open in New Window @ Context Menu Item", "Context menu item for opening the target item in a new window."), () => {
             const frame = null;
             WI.openURL(url, frame, {alwaysOpenExternally: true});