Changeset 276693 in webkit

Timestamp:

Apr 28, 2021, 12:00:47 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

ANGLE should be compiled with thread-safe statics
​https://bugs.webkit.org/show_bug.cgi?id=224854

Patch by Kimmo Kinnunen <​kkinnunen@apple.com> on 2021-04-28
Reviewed by Kenneth Russell.

Compile ANGLE with normal thread-safe c++ local statics.
No known threading failures. Based on ad-hoc risk vs benefit
evaluation of today and after future merges, it appears
better to err in the side of caution.

• Configurations/Base.xcconfig:

Location:

trunk/Source/ThirdParty/ANGLE

Files:

• ChangeLog (modified) (1 diff)
• Configurations/Base.xcconfig (modified) (1 diff)

trunk/Source/ThirdParty/ANGLE/ChangeLog

@@ +1 @@
+2021-04-28  Kimmo Kinnunen  <kkinnunen@apple.com>
+
+        ANGLE should be compiled with thread-safe statics
+        https://bugs.webkit.org/show_bug.cgi?id=224854
+
+        Reviewed by Kenneth Russell.
+
+        Compile ANGLE with normal thread-safe c++ local statics.
+        No known threading failures. Based on ad-hoc risk vs benefit
+        evaluation of today and after future merges, it appears
+        better to err in the side of caution.
+
+        * Configurations/Base.xcconfig:
+
 2021-04-26  Alex Christensen  <achristensen@webkit.org>
 

trunk/Source/ThirdParty/ANGLE/Configurations/Base.xcconfig

@@ -49 +49 @@
 GCC_PRECOMPILE_PREFIX_HEADER = NO;
 GCC_SYMBOLS_PRIVATE_EXTERN = YES;
-GCC_THREADSAFE_STATICS = NO;
 GCC_TREAT_WARNINGS_AS_ERRORS = YES;
 GCC_VERSION = com.apple.compilers.llvm.clang.1_0;