Changeset 276748 in webkit

Timestamp:

Apr 28, 2021, 8:55:51 PM (5 years ago)

Author:

rniwa@webkit.org

Message:

Use a WeakHashSet for Document::m_mediaElements
​https://bugs.webkit.org/show_bug.cgi?id=225082

Unreviewed. Address the review comments by Chris & Darin.

• dom/Document.cpp:

(WebCore::Document::forEachMediaElement):

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• dom/Document.cpp (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-04-28  Ryosuke Niwa  <rniwa@webkit.org>
+
+        Use a WeakHashSet for Document::m_mediaElements
+        https://bugs.webkit.org/show_bug.cgi?id=225082
+
+        Unreviewed. Address the review comments by Chris & Darin.
+
+        * dom/Document.cpp:
+        (WebCore::Document::forEachMediaElement):
+
 2021-04-28  Chris Dumez  <cdumez@apple.com>
 

trunk/Source/WebCore/dom/Document.cpp

@@ -1873 +1873 @@
     ASSERT(!m_mediaElements.hasNullReferences());
     m_mediaElements.forEach([&](auto& element) {
-        auto protectedElement = makeRef(element);
-        function(element);
+        function(makeRef(element));
     });
 }