Changeset 277133 in webkit

Timestamp:

May 6, 2021 3:30:16 PM (3 years ago)

Author:

fpizlo@apple.com

Message:

Remove old and unused memory barrier abstractions
​https://bugs.webkit.org/show_bug.cgi?id=225487

Reviewed by Mark Lam.

We don't use memoryBarrierBlahBlah anymore.

• wtf/Atomics.h:

(WTF::memoryBarrierAfterLock): Deleted.
(WTF::memoryBarrierBeforeUnlock): Deleted.

Location:

trunk/Source/WTF

Files:

• ChangeLog (modified) (1 diff)
• wtf/Atomics.h (modified) (3 diffs)

trunk/Source/WTF/ChangeLog

@@ +1 @@
+2021-05-06  Filip Pizlo  <fpizlo@apple.com>
+
+        Remove old and unused memory barrier abstractions
+        https://bugs.webkit.org/show_bug.cgi?id=225487
+
+        Reviewed by Mark Lam.
+
+        We don't use memoryBarrierBlahBlah anymore.
+
+        * wtf/Atomics.h:
+        (WTF::memoryBarrierAfterLock): Deleted.
+        (WTF::memoryBarrierBeforeUnlock): Deleted.
+
 2021-05-06  Filip Pizlo  <fpizlo@apple.com>
 

trunk/Source/WTF/wtf/Atomics.h

@@ -275 +275 @@
 inline void storeLoadFence() { arm_dmb(); }
 inline void storeStoreFence() { arm_dmb_st(); }
-inline void memoryBarrierAfterLock() { arm_dmb(); }
-inline void memoryBarrierBeforeUnlock() { arm_dmb(); }
 inline void crossModifyingCodeFence() { arm_isb(); }
 
@@ -313 +311 @@
 inline void storeLoadFence() { x86_ortop(); }
 inline void storeStoreFence() { compilerFence(); }
-inline void memoryBarrierAfterLock() { compilerFence(); }
-inline void memoryBarrierBeforeUnlock() { compilerFence(); }
 inline void crossModifyingCodeFence() { x86_cpuid(); }
 
@@ -323 +319 @@
 inline void storeLoadFence() { std::atomic_thread_fence(std::memory_order_seq_cst); }
 inline void storeStoreFence() { std::atomic_thread_fence(std::memory_order_seq_cst); }
-inline void memoryBarrierAfterLock() { std::atomic_thread_fence(std::memory_order_seq_cst); }
-inline void memoryBarrierBeforeUnlock() { std::atomic_thread_fence(std::memory_order_seq_cst); }
 inline void crossModifyingCodeFence() { std::atomic_thread_fence(std::memory_order_seq_cst); } // Probably not strong enough.