Changeset 277328 in webkit

Timestamp:

May 11, 2021, 10:16:06 AM (5 years ago)

Author:

commit-queue@webkit.org

Message:

Unreviewed, reverting r277322.
​https://bugs.webkit.org/show_bug.cgi?id=225657

Causing build failure

Reverted changeset:

"Adopt CoreMedia SPI to identify audio-only playback for MSE
clients"
​https://bugs.webkit.org/show_bug.cgi?id=225647
​https://trac.webkit.org/changeset/277322

Location:

trunk/Source/WebCore

Files:

• ChangeLog (modified) (1 diff)
• PAL/ChangeLog (modified) (1 diff)
• PAL/pal/spi/cocoa/AVFoundationSPI.h (modified) (2 diffs)
• platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm (modified) (1 diff)

trunk/Source/WebCore/ChangeLog

@@ +1 @@
+2021-05-11  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, reverting r277322.
+        https://bugs.webkit.org/show_bug.cgi?id=225657
+
+        Causing build failure
+
+        Reverted changeset:
+
+        "Adopt CoreMedia SPI to identify audio-only playback for MSE
+        clients"
+        https://bugs.webkit.org/show_bug.cgi?id=225647
+        https://trac.webkit.org/changeset/277322
+
 2021-05-11  Zalan Bujtas  <zalan@apple.com>
 

trunk/Source/WebCore/PAL/ChangeLog

@@ +1 @@
+2021-05-11  Commit Queue  <commit-queue@webkit.org>
+
+        Unreviewed, reverting r277322.
+        https://bugs.webkit.org/show_bug.cgi?id=225657
+
+        Causing build failure
+
+        Reverted changeset:
+
+        "Adopt CoreMedia SPI to identify audio-only playback for MSE
+        clients"
+        https://bugs.webkit.org/show_bug.cgi?id=225647
+        https://trac.webkit.org/changeset/277322
+
 2021-05-11  Jean-Yves Avenard  <jya@apple.com>
 

trunk/Source/WebCore/PAL/pal/spi/cocoa/AVFoundationSPI.h

@@ -339 +339 @@
 #if __has_include(<AVFoundation/AVSampleBufferAudioRenderer.h>)
 #import <AVFoundation/AVSampleBufferAudioRenderer.h>
-NS_ASSUME_NONNULL_BEGIN
-@interface AVSampleBufferAudioRenderer (AVSampleBufferAudioRendererWebKitOnly)
-- (void)setIsUnaccompaniedByVisuals:(BOOL)audioOnly SPI_AVAILABLE(macos(12.0)) API_UNAVAILABLE(ios, tvos, watchos);
-@end
-NS_ASSUME_NONNULL_END
 #else
 
@@ -358 +353 @@
 - (void)setVolume:(float)volume;
 - (void)setMuted:(BOOL)muted;
-- (void)setIsUnaccompaniedByVisuals:(BOOL)audioOnly;
 @property (nonatomic, copy) NSString *audioTimePitchAlgorithm;
 @end

trunk/Source/WebCore/platform/graphics/avfoundation/objc/MediaPlayerPrivateMediaSourceAVFObjC.mm

@@ -1170 +1170 @@
     [audioRenderer setVolume:m_player->volume()];
     [audioRenderer setAudioTimePitchAlgorithm:(m_player->preservesPitch() ? AVAudioTimePitchAlgorithmSpectral : AVAudioTimePitchAlgorithmVarispeed)];
-    ALLOW_NEW_API_WITHOUT_GUARDS_BEGIN
-    if ([audioRenderer respondsToSelector:@selector(setIsUnaccompaniedByVisuals:)])
-        [audioRenderer setIsUnaccompaniedByVisuals:!m_player->isVideoPlayer()];
-    ALLOW_NEW_API_WITHOUT_GUARDS_END
 
 #if HAVE(AUDIO_OUTPUT_DEVICE_UNIQUE_ID)